8000 tests(erc20): add integration tests by danburck · Pull Request #571 · evmos/evmos · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

tests(erc20): add integration tests #571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
May 6, 2022
Merged

Conversation

danburck
Copy link
Contributor
@danburck danburck commented May 6, 2022

Description

This PR adds integration tests for successful ERC20 and Coin conversion paths

@linear
Copy link
linear bot commented May 6, 2022

@codecov
Copy link
codecov bot commented May 6, 2022

Codecov Report

Merging #571 (76d5fb4) into main (2310c18) will increase coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #571      +/-   ##
==========================================
+ Coverage   83.39%   83.47%   +0.07%     
==========================================
  Files         114      114              
  Lines        6330     6330              
==========================================
+ Hits         5279     5284       +5     
+ Misses        924      920       -4     
+ Partials      127      126       -1     
Impacted Files Coverage Δ
x/erc20/keeper/mint.go 100.00% <0.00%> (+12.82%) ⬆️

@danburck danburck changed the title ENG 244 erc20 integration tests tests(erc20): add integration tests May 6, 2022
@danburck danburck marked this pull request as ready for review May 6, 2022 15:35
Copy link
Collaborator
@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, can you add a test when the token pair is disabled?

@fedekunze fedekunze merged commit 35e8396 into main May 6, 2022
@fedekunze fedekunze deleted the ENG-244-erc20-integration-tests branch May 6, 2022 18:34
loredanacirstea added a commit that referenced this pull request May 11, 2022
* main: (24 commits)
  docs: update hardhat guide (#594)
  audit(erc20): completeness (#592)
  fix: readd erc20 migration logic (#588)
  release: v3.0.1 changelog (#584)
  release: set v4 upgrade heights (#581)
  docs: fix more problems with markdown link check (#575)
  bump(ethermint): v0.15.0 (#580)
  ci: update mergify config (#579)
  release: v4 upgrade logic (#555)
  docs: upgrade deps (#578)
  docs: upgrade documentation (#572)
  Correct testnet endpoint URLs (#577)
  build(deps): bump docker/setup-qemu-action from 1 to 2 (#566)
  build(deps): bump docker/setup-buildx-action from 1 to 2 (#567)
  ci(fuzz): add fuzz function for x/incentives/types.SplitGasMeterKey (#573)
  tests(erc20): add integration tests (#571)
  build(deps): bump docker/login-action from 1 to 2 (#565)
  tests(erc20): refactor keeper tests (#561)
  Use universal cosmos gitpod image as an editing environment (#564)
  build(deps): bump docker/build-push-action from 2 to 3 (#568)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0