-
Notifications
You must be signed in to change notification settings - Fork 902
tests(erc20): add integration tests #571
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #571 +/- ##
==========================================
+ Coverage 83.39% 83.47% +0.07%
==========================================
Files 114 114
Lines 6330 6330
==========================================
+ Hits 5279 5284 +5
+ Misses 924 920 -4
+ Partials 127 126 -1
|
…evmos into ENG-244-erc20-integration-tests
fedekunze
approved these changes
May 6, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, can you add a test when the token pair is disabled?
loredanacirstea
added a commit
that referenced
this pull request
May 11, 2022
* main: (24 commits) docs: update hardhat guide (#594) audit(erc20): completeness (#592) fix: readd erc20 migration logic (#588) release: v3.0.1 changelog (#584) release: set v4 upgrade heights (#581) docs: fix more problems with markdown link check (#575) bump(ethermint): v0.15.0 (#580) ci: update mergify config (#579) release: v4 upgrade logic (#555) docs: upgrade deps (#578) docs: upgrade documentation (#572) Correct testnet endpoint URLs (#577) build(deps): bump docker/setup-qemu-action from 1 to 2 (#566) build(deps): bump docker/setup-buildx-action from 1 to 2 (#567) ci(fuzz): add fuzz function for x/incentives/types.SplitGasMeterKey (#573) tests(erc20): add integration tests (#571) build(deps): bump docker/login-action from 1 to 2 (#565) tests(erc20): refactor keeper tests (#561) Use universal cosmos gitpod image as an editing environment (#564) build(deps): bump docker/build-push-action from 2 to 3 (#568) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds integration tests for successful ERC20 and Coin conversion paths