8000 Update tutorial by pkooij · Pull Request #1021 · huggingface/lerobot · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Update tutorial #1021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Apr 28, 2025
Merged

Update tutorial #1021

merged 15 commits into from
Apr 28, 2025

Conversation

pkooij
Copy link
Member
@pkooij pkooij commented Apr 23, 2025 •
edited
Loading

What this does

This PR adds tutorial

  • Add extra SO tutorial with more extensive examples and documentation.
    - Thus it can serve as a good main lerobot tutorial
    - Add assembly video in readme

  • Also adds the extra calibration step that we used in hackathon

  • Adds so101 class, which we ca modify later to enable the leader arm mirroring the follower arm

  • Change main readme with images and updated text

Note: DO NOT MERGE YET

@pkooij pkooij added documentation Improvements or fixes to the project’s docs enhancement Suggestions for new features or improvements robots Issues concerning robots HW interfaces labels Apr 23, 2025
@pkooij pkooij self-assigned this Apr 23, 2025
@pkooij pkooij requested review from imstevenpmwork and Cadene April 23, 2025 12:38
@pkooij pkooij marked this pull request as draft April 23, 2025 13:45
Cadene
Cadene reviewed Apr 23, 2025
View reviewed changes
Copy link
Collaborator
@Cadene Cadene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! No blocker on my side. Waiting for review of @aliberts ;)

@Cadene Cadene requested a review from aliberts April 23, 2025 15:22
imstevenpmwork
imstevenpmwork reviewed Apr 23, 2025
View reviewed changes
Copy link
Collaborator
@imstevenpmwork imstevenpmwork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a minor comment related to the installation instructions, but otherwise LGTM. Love the new assembling video animations, good job 🚀

aliberts
aliberts approved these changes Apr 24, 2025
View reviewed changes
Copy link
Collaborator
@aliberts aliberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM although didn't look in detail as this will all get updated very soon in the robots refactor PR so don't want to spend much time reviewing here. I'm trusting you that it works on the actual robot ^^

@pkooij pkooij marked this pull request as ready for review April 25, 2025 16:08
@pkooij pkooij merged commit 42bf1e8 into main Apr 28, 2025
7 checks passed
@pkooij pkooij deleted the user/pepijn_2025_04_15_update_tutorial branch April 28, 2025 07:00
asafxrev pushed a commit to asafxrev/lerobot that referenced this pull request May 2, 2025
@pkooij @aliberts @asafxrev
Update tutorial (huggingface#1021)
69d6b42 
Co-authored-by: Simon Alibert <75076266+aliberts@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cadene Cadene Cadene left review comments

@imstevenpmwork imstevenpmwork imstevenpmwork left review comments

@aliberts aliberts aliberts approved these changes

Assignees

@pkooij pkooij

Labels
documentation Improvements or fixes to the project’s docs enhancement Suggestions for new features or improvements robots Issues concerning robots HW interfaces
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pkooij @Cadene @imstevenpmwork @aliberts
0