8000 [No functional change] Update tests by voldyman · Pull Request #1036 · huggingface/lerobot · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[No functional change] Update tests #1036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

voldyman
Copy link

What this does

There are 2 changes in this PR:

  1. Switch to use importlib.resources instead of reading file paths
  2. renamed tests/utils.py -> tests/testutils.py

neither of the changes have any functional impact but make it easy to integrate lerobot with other codebases.

Switch to importlib.resources

when lerobot repo is embedded within another project, the Path(__file__) logic breaks, using importlib.resources makes it resilient and is supported by the build systems directly.

Renaming utils.py

In the tests folders, there is a folder called utils and a file called utils.py, this confuses alternative build systems and is easier to use different names rather than overload them.

@voldyman voldyman changed the title Fix tests [No functional change] Update tests Apr 26, 2025
@imstevenpmwork imstevenpmwork added enhancement Suggestions for new features or improvements tests Problems with test coverage, failures, or improvements to testing labels Apr 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Suggestions for new features or improvements tests Problems with test coverage, failures, or improvements to testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0