fix(config): typing correction on config.py #1320
Open
+8
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Although not affecting the execution, the typing in some of the fields in Config are actually wrong. For example, the task field in subclass of `EnvConfig` are typed inconsistently, leading the basedpyright warning: ``` basedpyright: "task" overrides symbol of same name in class "EnvConfig" Variable is mutable so its type is invariant Override type "str" is not the same as base type "str | None" [reportIncompatibleVariableOverride] ``` Secondly, the override of `gym_kwargs` in `HILSerlRobotEnvConfig` miss the property decorator, leading the following linter problem: ``` basedpyright: "gym_kwargs" incorrectly overrides property of same name in class "EnvConfig" [reportIncompatibleMethodOverride] ``` This commit enforces more strict typing on this file.
for more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although not affecting the execution, the typing in some of the fields in
config.pyare actually wrong.For example, the task field in subclass of
EnvConfigare typed inconsistently, leading the basedpyright warning:Secondly, the override of
gym_kwargsinHILSerlRobotEnvConfigmiss the property decorator, leading the following linter problem:This commit enforces more strict typing on this file.