-
Notifications
You must be signed in to change notification settings - Fork 1.6k
feat(arx): support arx arm #364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
villekuosmanen
wants to merge
34
commits into
huggingface:main
Choose a base branch
from
villekuosmanen:feat/arx-arm
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
34 commits
Select commit
Hold shift + click to select a range
68f6ba2
feat(arx): support arx arm
villekuosmanen 295996b
changes
villekuosmanen 3a96695
changes
villekuosmanen 9ef5943
changes
villekuosmanen c1d5874
changes
villekuosmanen 3680bc5
pass pipes explicitly
villekuosmanen 0a14950
changes
villekuosmanen cafc17f
us ndarray over a pipe
villekuosmanen dc61b19
changes
villekuosmanen bf2f466
changes
villekuosmanen 513f87b
replay basically works
villekuosmanen 54dc549
patch arx sdk
villekuosmanen 05efb73
Merge branch 'main' into feat/arx-arm
villekuosmanen 1ba37d1
changes
villekuosmanen 03bb9e8
support cameras in arx5
villekuosmanen ba1fc38
rename to arx5
villekuosmanen e78700f
kind of works
villekuosmanen 0ada58b
changes
villekuosmanen ff92b7c
changes
villekuosmanen ad9fca9
changes
villekuosmanen 8acd403
various changes
villekuosmanen e8d1633
Merge branch 'main' into feat/arx-arm
villekuosmanen 7c62571
changes
villekuosmanen 201fd7a
revert a few changes
villekuosmanen cdbe578
changes
villekuosmanen 997f650
changes
villekuosmanen cb7b6ac
Merge branch 'main' into feat/arx-arm
villekuosmanen f900206
changes
villekuosmanen 1fc6fd2
Merge branch 'main' into feat/arx-arm
villekuosmanen 92beb46
changes
villekuosmanen 012122f
Merge branch 'main' into feat/arx-arm
villekuosmanen e1d9e44
changes
villekuosmanen 4bce19b
changes
villekuosmanen 9084667
Merge branch 'main' into feat/arx-arm
villekuosmanen File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -333,6 +333,9 @@ def connect(self): | |
# needs to be re-created. | ||
self.camera = cv2.VideoCapture(camera_idx) | ||
|
||
if not self.camera.isOpened(): | ||
raise OSError(f"Camera {self.camera_index} could not be opened.") | ||
Comment on lines
+336
to
+337
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I was getting a strange issue where you could create the camera but it did not open. forgot why exactly but this helped debug it. |
||
|
||
if self.fps is not None: | ||
self.camera.set(cv2.CAP_PROP_FPS, self.fps) | ||
if self.width is not None: | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this was wrong before, though not sure if it is actually used. happy to revert it if necessary.