8000 feat(arx): support arx arm by villekuosmanen · Pull Request #364 · huggingface/lerobot · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat(arx): support arx arm #364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 34 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
34 commits
Select commit Hold shift + click to select a range
68f6ba2
feat(arx): support arx arm
villekuosmanen Aug 18, 2024
295996b
changes
villekuosmanen Aug 18, 2024
3a96695
changes
villekuosmanen Aug 18, 2024
9ef5943
changes
villekuosmanen Aug 19, 2024
c1d5874
changes
villekuosmanen Aug 19, 2024
3680bc5
pass pipes explicitly
villekuosmanen Aug 19, 2024
0a14950
changes
villekuosmanen Aug 19, 2024
cafc17f
us ndarray over a pipe
villekuosmanen Aug 19, 2024
dc61b19
changes
villekuosmanen Aug 19, 2024
bf2f466
changes
villekuosmanen Aug 19, 2024
513f87b
replay basically works
villekuosmanen Aug 19, 2024
54dc549
patch arx sdk
villekuosmanen Aug 23, 2024
05efb73
Merge branch 'main' into feat/arx-arm
villekuosmanen Aug 23, 2024
1ba37d1
changes
villekuosmanen Aug 23, 2024
03bb9e8
support cameras in arx5
villekuosmanen Aug 23, 2024
ba1fc38
rename to arx5
villekuosmanen Aug 23, 2024
e78700f
kind of works
villekuosmanen Aug 23, 2024
0ada58b
changes
villekuosmanen Aug 25, 2024
ff92b7c
changes
villekuosmanen Aug 26, 2024
ad9fca9
changes
villekuosmanen Aug 30, 2024
8acd403
various changes
villekuosmanen Aug 30, 2024
e8d1633
Merge branch 'main' into feat/arx-arm
villekuosmanen Aug 30, 2024
7c62571
changes
villekuosmanen Sep 2, 2024
201fd7a
revert a few changes
villekuosmanen Sep 2, 2024
cdbe578
changes
villekuosmanen Sep 2, 2024
997f650
changes
villekuosmanen Sep 13, 2024
cb7b6ac
Merge branch 'main' into feat/arx-arm
villekuosmanen Sep 13, 2024
f900206
changes
villekuosmanen Sep 16, 2024
1fc6fd2
Merge branch 'main' into feat/arx-arm
villekuosmanen Sep 20, 2024
92beb46
changes
villekuosmanen Sep 27, 2024
012122f
Merge branch 'main' into feat/arx-arm
villekuosmanen Oct 5, 2024
e1d9e44
changes
villekuosmanen Oct 5, 2024
4bce19b
changes
villekuosmanen Nov 1, 2024
9084667
Merge branch 'main' into feat/arx-arm
villekuosmanen Nov 1, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lerobot/common/datasets/push_dataset_to_hub/cam_png_format.py
Original file line number Diff line number Diff line change
Expand Up @@ -88,12 +88,12 @@ def from_raw_to_lerobot_format(
raise NotImplementedError

# sanity check
check_format(raw_dir)
check_format(videos_dir)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this was wrong before, though not sure if it is actually used. happy to revert it if necessary.


if fps is None:
fps = 30

data_dict = load_from_raw(raw_dir, videos_dir, fps, video, episodes)
data_dict = load_from_raw(videos_dir, fps, video, episodes)
8000 hf_dataset = to_hf_dataset(data_dict, video)
episode_data_index = calculate_episode_data_index(hf_dataset)
info = {
Expand Down
3 changes: 3 additions & 0 deletions lerobot/common/robot_devices/cameras/opencv.py
Original file line number Diff line number Diff line change
Expand Up @@ -333,6 +333,9 @@ def connect(self):
# needs to be re-created.
self.camera = cv2.VideoCapture(camera_idx)

if not self.camera.isOpened():
raise OSError(f"Camera {self.camera_index} could not be opened.")
Comment on lines +336 to +337
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was getting a strange issue where you could create the camera but it did not open. forgot why exactly but this helped debug it.


if self.fps is not None:
self.camera.set(cv2.CAP_PROP_FPS, self.fps)
if self.width is not None:
Expand Down
7 changes: 7 additions & 0 deletions lerobot/common/robot_devices/control_utils.py
708A
Original file line number Diff line number Diff line change
Expand Up @@ -125,6 +125,7 @@ def init_keyboard_listener():
events["exit_early"] = False
events["rerecord_episode"] = False
events["stop_recording"] = False
events["reset_robot"] = False

if is_headless():
logging.warning(
Expand All @@ -149,6 +150,9 @@ def on_press(key):
print("Escape key pressed. Stopping data recording...")
events["stop_recording"] = True
events["exit_early"] = True
elif key == keyboard.Key.down:
print("Resetting robot...")
events["reset_robot"] = True
except Exception as e:
print(f"Error handling key press: {e}")

Expand Down Expand Up @@ -307,6 +311,9 @@ def reset_environment(robot, events, reset_time_s):
if events["exit_early"]:
events["exit_early"] = False
break
if events["reset_robot"]:
robot.reset()
events["reset_robot"] = False


def stop_recording(robot, listener, display_cameras):
Expand Down
Loading
0