optimization: Speed up image saving procedure #381
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a3a6a05 to
ac2e1de
Compare
|
Very interesting PR! Thanks |
Use pyav (ffmpeg) to save image ratherthan PIL (which is slower)
ac2e1de to
d16fe1d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this does
PIL save require time consuming image encoding, which is slow, and cause image queue backing up and make a OOM when doing a realtime teleoprate.
With pyav, we can make is much faster and less resource usage.
How it was tested
TODO benchmarking
How to checkout & try? (for the reviewer)
Close #360