This repository was archived by the owner on Mar 24, 2025. It is now read-only.
refactor: remove market config from oracle and providers #132
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aljo242
reviewed
Feb 15, 2024
|
tests failing |
|
tests will keep failing till all other changes are merged into this branch |
| @@ -59,63 +59,63 @@ const ( | |||
| // WebSocketConfig defines a config for a websocket based data provider. | |||
| type WebSocketConfig struct { | |||
| // Enabled is a flag that indicates whether the provider is websocket based. | |||
| Enabled bool `mapstructure:"enabled" toml:"enabled"` | |||
| Enabled bool `json:"enabled"` | |||
There was a problem hiding this comment.
Wasn't the Enabled field mostly put in place to work around peculiarities w/ generating configs via toml? I'm thinking it doesn't make sense to have now--a provider will be enabled if there are feeds for it to fetch and disabled if not.
| // Market defines the market configurations for how currency pairs will be resolved to a | ||
| // final price. Each currency pair can have a list of convertable markets that will be used | ||
| // to convert the price of the currency pair to a common currency pair. | ||
| Market AggregateMarketConfig `mapstructure:"market" toml:"market"` |
There was a problem hiding this comment.
How is the aggregation logic going to be configured now without AggregateMarketConfig?
There was a problem hiding this comment.
going to reference the marketmap module, which will have the relevant market information.
* type swap * alias * alias * use constants in tests
* binance * coinbase and coingecko * nits * static * type alias maximalism * format
* coinbase and coingecko * nits * bitfinex * bitstamp * bybit * nits * nit * websocket first pass * nits * format
* init * testing * more testing * cr
…162) * init * testing * more testing * cr * init * nits * update * nits --------- Co-authored-by: aljo242 <alex@skip.money>
* init * testing * more testing * cr * init * nits * init * nits * e2e fixes * cr nits
aljo242
approved these changes
Feb 21, 2024
aljo242
pushed a commit
that referenced
this pull request
Feb 22, 2024
* init * rm mapstructure * chore: swapping types in the main oracle to use ticker (#133) * type swap * alias * alias * use constants in tests * chore: Updating API providers with new types (#139) * binance * coinbase and coingecko * nits * static * type alias maximalism * format * chore: Updating all WS providers with new types (#143) * coinbase and coingecko * nits * bitfinex * bitstamp * bybit * nits * nit * websocket first pass * nits * format * chore: Updating types based on new marketmap schema (#155) * init * testing * more testing * cr * chore: Updating provider factories with new market map configuration (#162) * init * testing * more testing * cr * init * nits * update * nits --------- Co-authored-by: aljo242 <alex@skip.money> * chore: Updating conversion aggregation function (#164) * init * testing * more testing * cr * init * nits * init * nits * e2e fixes * cr nits --------- Co-authored-by: Alex Johnson <alex@skip.money>
aljo242
pushed a commit
that referenced
this pull request
Feb 22, 2024
* gen new * msg * fix * add test * fix * gen new proto * generalize * fix * format * test * fully test * update * fix * ok * ok * Update x/marketmap/keeper/msg_server.go Co-authored-by: David Terpay <35130517+davidterpay@users.noreply.github.com> * Update x/marketmap/keeper/msg_server.go Co-authored-by: David Terpay <35130517+davidterpay@users.noreply.github.com> * refactor: remove market config from oracle and providers (#132) * init * rm mapstructure * chore: swapping types in the main oracle to use ticker (#133) * type swap * alias * alias * use constants in tests * chore: Updating API providers with new types (#139) * binance * coinbase and coingecko * nits * static * type alias maximalism * format * chore: Updating all WS providers with new types (#143) * coinbase and coingecko * nits * bitfinex * bitstamp * bybit * nits * nit * websocket first pass * nits * format * chore: Updating types based on new marketmap schema (#155) * init * testing * more testing * cr * chore: Updating provider factories with new market map configuration (#162) * init * testing * more testing * cr * init * nits * update * nits --------- Co-authored-by: aljo242 <alex@skip.money> * chore: Updating conversion aggregation function (#164) * init * testing * more testing * cr * init * nits * init * nits * e2e fixes * cr nits --------- Co-authored-by: Alex Johnson <alex@skip.money> * update * godoc * update validation * feat: emit events for creating market (#163) * constants * create market event --------- Co-authored-by: David Terpay <35130517+davidterpay@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: This PR is breaking and must be merged into
feat/marketmapafter all other PRs that branch on this are merged here.