This repository was archived by the owner on Mar 24, 2025. It is now read-only.
chore: Updating types based on new marketmap schema #155
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aljo242
reviewed
Feb 20, 2024
|
needs format and tests failing |
aljo242
reviewed
Feb 21, 2024
| } | ||
|
|
||
| // ValidateBasic performs basic validation on the provider market map. | ||
| func (pmm ProviderMarketMap) ValidateBasic() error { |
There was a problem hiding this comment.
Suggested change
| func (pmm ProviderMarketMap) ValidateBasic() error { | |
| func (pmm *ProviderMarketMap) ValidateBasic() error { |
aljo242
reviewed
Feb 21, 2024
Comment on lines
22
to
+23
| // market is the config for the Binance API. | ||
| market mmtypes.MarketConfig | ||
| market types.ProviderMarketMap |
There was a problem hiding this comment.
These comments could be a bit more specific.
"market is the market config for the Binance API"
"api is the api config for the Binance API"
aljo242
approved these changes
Feb 21, 2024
aljo242
approved these changes
Feb 21, 2024
aljo242
approved these changes
Feb 21, 2024
davidterpay
added a commit
that referenced
this pull request
Feb 21, 2024
* init * rm mapstructure * chore: swapping types in the main oracle to use ticker (#133) * type swap * alias * alias * use constants in tests * chore: Updating API providers with new types (#139) * binance * coinbase and coingecko * nits * static * type alias maximalism * format * chore: Updating all WS providers with new types (#143) * coinbase and coingecko * nits * bitfinex * bitstamp * bybit * nits * nit * websocket first pass * nits * format * chore: Updating types based on new marketmap schema (#155) * init * testing * more testing * cr * chore: Updating provider factories with new market map configuration (#162) * init * testing * more testing * cr * init * nits * update * nits --------- Co-authored-by: aljo242 <alex@skip.money> * chore: Updating conversion aggregation function (#164) * init * testing * more testing * cr * init * nits * init * nits * e2e fixes * cr nits --------- Co-authored-by: Alex Johnson <alex@skip.money>
aljo242
pushed a commit
that referenced
this pull request
Feb 22, 2024
* init * rm mapstructure * chore: swapping types in the main oracle to use ticker (#133) * type swap * alias * alias * use constants in tests * chore: Updating API providers with new types (#139) * binance * coinbase and coingecko * nits * static * type alias maximalism * format * chore: Updating all WS providers with new types (#143) * coinbase and coingecko * nits * bitfinex * bitstamp * bybit * nits * nit * websocket first pass * nits * format * chore: Updating types based on new marketmap schema (#155) * init * testing * more testing * cr * chore: Updating provider factories with new market map configuration (#162) * init * testing * more testing * cr * init * nits * update * nits --------- Co-authored-by: aljo242 <alex@skip.money> * chore: Updating conversion aggregation function (#164) * init * testing * more testing * cr * init * nits * init * nits * e2e fixes * cr nits --------- Co-authored-by: Alex Johnson <alex@skip.money>
aljo242
pushed a commit
that referenced
this pull request
Feb 22, 2024
* gen new * msg * fix * add test * fix * gen new proto * generalize * fix * format * test * fully test * update * fix * ok * ok * Update x/marketmap/keeper/msg_server.go Co-authored-by: David Terpay <35130517+davidterpay@users.noreply.github.com> * Update x/marketmap/keeper/msg_server.go Co-authored-by: David Terpay <35130517+davidterpay@users.noreply.github.com> * refactor: remove market config from oracle and providers (#132) * init * rm mapstructure * chore: swapping types in the main oracle to use ticker (#133) * type swap * alias * alias * use constants in tests * chore: Updating API providers with new types (#139) * binance * coinbase and coingecko * nits * static * type alias maximalism * format * chore: Updating all WS providers with new types (#143) * coinbase and coingecko * nits * bitfinex * bitstamp * bybit * nits * nit * websocket first pass * nits * format * chore: Updating types based on new marketmap schema (#155) * init * testing * more testing * cr * chore: Updating provider factories with new market map configuration (#162) * init * testing * more testing * cr * init * nits * update * nits --------- Co-authored-by: aljo242 <alex@skip.money> * chore: Updating conversion aggregation function (#164) * init * testing * more testing * cr * init * nits * init * nits * e2e fixes * cr nits --------- Co-authored-by: Alex Johnson <alex@skip.money> * update * godoc * update validation * feat: emit events for creating market (#163) * constants * create market event --------- Co-authored-by: David Terpay <35130517+davidterpay@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes BLO-859