This repository was archived by the owner on Mar 24, 2025. It is now read-only.
feat: msg-server v2 #156
Merged
feat: msg-server v2 #156
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## feat/marketmap #156 +/- ##
==================================================
+ Coverage 59.11% 59.31% +0.19%
==================================================
Files 226 228 +2
Lines 8974 9040 +66
==================================================
+ Hits 5305 5362 +57
- Misses 3019 3025 +6
- Partials 650 653 +3 ☔ View full report in Codecov by Sentry. |
davidterpay
reviewed
Feb 22, 2024
davidterpay
reviewed
Feb 22, 2024
davidterpay
reviewed
Feb 22, 2024
davidterpay
reviewed
Feb 22, 2024
davidterpay
reviewed
Feb 22, 2024
davidterpay
reviewed
Feb 22, 2024
Co-authored-by: David Terpay <35130517+davidterpay@users.noreply.github.com>
davidterpay
reviewed
Feb 22, 2024
Co-authored-by: David Terpay <35130517+davidterpay@users.noreply.github.com>
davidterpay
approved these changes
Feb 22, 2024
* init * rm mapstructure * chore: swapping types in the main oracle to use ticker (#133) * type swap * alias * alias * use constants in tests * chore: Updating API providers with new types (#139) * binance * coinbase and coingecko * nits * static * type alias maximalism * format * chore: Updating all WS providers with new types (#143) * coinbase and coingecko * nits * bitfinex * bitstamp * bybit * nits * nit * websocket first pass * nits * format * chore: Updating types based on new marketmap schema (#155) * init * testing * more testing * cr * chore: Updating provider factories with new market map configuration (#162) * init * testing * more testing * cr * init * nits * update * nits --------- Co-authored-by: aljo242 <alex@skip.money> * chore: Updating conversion aggregation function (#164) * init * testing * more testing * cr * init * nits * init * nits * e2e fixes * cr nits --------- Co-authored-by: Alex Johnson <alex@skip.money>
* constants * create market event
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add basic msg server with
MsgUpdateMarketMapkeeper.ValidateStatethat ensures all currency pairs included in paths are already stored in state (unless the path is the currency pair itself). This function can be called after all batched updates to the market map to verify the validity of the resulting state.MsgUpdateMarketMapwill be the main transaction that can interact with the module. Currently is has the fieldCreateMarketswhich is the list of markets to be created. Later, this can be extended in a compatible way to addUpdateMarketsandDeleteMarketsif desired, each with their own logic.will need to be updated with a message for setting params.