10000 fix: Add missed source files to mso target and fix name of targets by Czaki · Pull Request #51 · 4DNucleome/PartSegCore-compiled-backend · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: Add missed source files to mso target and fix name of targets #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 25, 2024
Merged

fix: Add missed source files to mso target and fix name of targets #51

merged 1 commit into from
Oct 25, 2024

Conversation

Czaki
Copy link
Contributor
@Czaki Czaki commented Oct 25, 2024 •
edited by coderabbitai bot
Loading

Resolve problems spotted when developing #50

Summary by CodeRabbit

  • Chores
    • Updated library names and installation targets for Python libraries to improve clarity and organization.
    • Added additional header files to the mso_bind library for enhanced functionality.

@coderabbitai coderabbitai
Copy link
Contributor
coderabbitai bot commented Oct 25, 2024 •
edited
Loading

Walkthrough

The changes involve modifications to the CMakeLists.txt file, primarily focusing on renaming several Python libraries and updating their installation targets. The libraries sprawl_utils_cython and fuzzy_distance_cython have been renamed to sprawl_utils and fuzzy_distance, respectively. Additionally, the mso_bind library command has been reformatted to include new header files. The installation commands for the renamed libraries have also been updated to reflect these changes.

Changes

File Change Summary
CMakeLists.txt - Renamed sprawl_utils_cython to sprawl_utils and updated related installation commands.
- Renamed fuzzy_distance_cython to fuzzy_distance and updated related installation commands.
- Reformatted mso_bind to include mso.h and my_queue.h in the command.

Poem

In the land of code where rabbits play,
Libraries renamed, hip-hip-hooray! 🐇✨
With sprawl_utils and fuzzy_distance,
Our builds now dance with new persistence.
Hopping along, we celebrate the change,
In the world of CMake, it's never too strange! 🌟

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 1669ee0 and 74573fa.

📒 Files selected for processing (1)
  • CMakeLists.txt (3 hunks)
🔇 Additional comments (4)
CMakeLists.txt (4)

93-94: LGTM: Installation targets properly updated.

The installation targets have been correctly updated to match the new library names while maintaining the correct destination paths.

52-54: LGTM: Library name change is consistent.

The rename from fuzzy_distance_cython to fuzzy_distance is properly reflected in all related commands.

Let's verify no references to the old name remain:

#!/bin/bash
# Search for any remaining references to the old name
rg "fuzzy_distance_cython" --type cmake

68-74: Verify if mso.cpp should be included.

There's a commented out source file mso.cpp. Since the PR objective mentions adding missed source files, we should verify if this file should be included in the build.

Let's check if the file exists and its contents:

#!/bin/bash
# Check if mso.cpp exists
if [ -f "src/PartSegCore_compiled_backend/multiscale_opening/mso.cpp" ]; then
    echo "mso.cpp exists. Contents:"
    cat "src/PartSegCore_compiled_backend/multiscale_opening/mso.cpp"
else
    echo "mso.cpp does not exist"
fi

# Check if the header files contain any inline implementations
echo -e "\nChecking mso.h for potential inline implementations:"
cat "src/PartSegCore_compiled_backend/multiscale_opening/mso.h"

46-48: LGTM: Library name change is consistent.

The rename from sprawl_utils_cython to sprawl_utils is properly reflected in all related commands.

Let's verify no references to the old name remain:

✅ Verification successful

Let me search for any remaining references to the old name in CMake files.

The reference to sprawl_utils_cython in line 1 is expected and correct

The remaining reference to sprawl_utils_cython is in the Cython transpilation command where it refers to the source .pyx file's output variable. This is not a target name but a CMake variable that temporarily holds the generated C++ source path. The actual library target is correctly named sprawl_utils in the subsequent python_add_library command.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Search for any remaining references to the old name
rg "sprawl_utils_cython" --type cmake

Length of output: 32871

Script:

#!/bin/bash
# Search for any remaining references to the old name in CMake files
rg "sprawl_utils_cython" --type cmake

Length of output: 281

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@Czaki Czaki merged commit 0f01b38 into master Oct 25, 2024
21 checks passed
@Czaki Czaki deleted the fix_cmake branch October 25, 2024 09:55
@Czaki Czaki mentioned this pull request Oct 25, 2024
Open
@coderabbitai coderabbitai bot mentioned this pull request Dec 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Czaki
0