feat(cli, next): support pre-release versions #204
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
augustoccesar
commented
Mar 18, 2025
Comment on lines
+40
to
+47
| (Some(_), None) => { | ||
| // pre-release is always lower than stable | ||
| Some(std::cmp::Ordering::Less) | ||
| } | ||
| (None, Some(_)) => { | ||
| // stable is always higher than pre-release | ||
| Some(std::cmp::Ordering::Greater) | ||
| } |
There was a problem hiding this comment.
This is more to protect against any accidental updates from beta channel into stable, and the other way around.
It shouldn't happen, since the available_update fetches from the same channel. But might be good to have.
# Conflicts: # linkup-cli/src/release.rs
bb5dfee to
fa3727b
Compare
charlottea98
approved these changes
Mar 21, 2025
augustoccesar
added a commit
that referenced
this pull request
Apr 9, 2025
This will be merged to release `3.0.0`. Closes SHIP-2057 ### Changelog: - Drop Caddy as a dependency and use self-signed certificates. - #201 - #207 - #212 - #215 - #217 - Drop dnsmasq as a dependency and use a local Hickory server. - #219 - #224 - Support pre-release (beta) versions based on changes to `next` branch. - #204 - #205 - #211 - #213 - #214 - #221 - Use anyhow for application errors instead of "global" thiserror enum. - #218 - Stop relying on pidfiles for background services - #222 - Move installation script from Bash to Python - #223 - #226 - Improve possible orphans resolution - #225 Thank you @diegomartinrecillas @ludwigbacklund @solveigsg12 and @jauniusmentimeter for beta testing it! ❤️
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support to pre-release versions on
versioning.Right now the only pre-release that will exist is
0.0.0-next-<timestamp>-<hash>, so if there is apre-releasepart of the version, we can ignore the base semver.PR for generating the pre-releases: #205
Closes SHIP-2016
Related to SHIP-2057