feat: local DNS server with Hickory #219
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new local DNS server implementation using Hickory instead of dnsmasq, updating multiple modules to integrate the new functionality. Key changes include:
- Adding a new async function to start a DNS server in local-server/src/lib.rs.
- Replacing dnsmasq usage with a new LocalDnsServer implementation in linkup-cli.
- Adjusting command and health check logic to accommodate the new DNS service integration.
Reviewed Changes
Copilot reviewed 13 out of 14 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| local-server/src/lib.rs | Added start_dns_server function using hickory_server libraries. |
| local-server/Cargo.toml | Added dependency on hickory-server and updated hyper-rustls config. |
| linkup-cli/src/services/mod.rs | Replaced dnsmasq declarations with LocalDnsServer integration. |
| linkup-cli/src/services/local_server.rs | Modified command startup logic for LocalServer. |
| linkup-cli/src/services/local_dns_server.rs | Introduced a new LocalDnsServer implementation. |
| linkup-cli/src/commands/stop.rs | Updated to stop LocalDnsServer instead of dnsmasq. |
| linkup-cli/src/commands/start.rs | Updated to start LocalDnsServer in place of dnsmasq on macOS. |
| linkup-cli/src/commands/server.rs | Added ServerKind::Dns support to start the DNS server. |
| linkup-cli/src/commands/health.rs | Updated background services health checks to include DNS Server. |
| docs/src/content/docs/explanation/how-it-works.md | Revised documentation to reflect the new local DNS service. |
Files not reviewed (1)
- linkup-cli/install.sh: Language not supported
Comments suppressed due to low confidence (3)
local-server/src/lib.rs:143
- Using unwrap here may cause a panic if the DNS name format is incorrect; consider using proper error handling.
let record_name = Name::from_str(&format("{linkup_session_name}.{domain}.")).unwrap();
linkup-cli/src/commands/health.rs:122
- The function local_dns::is_installed is referenced but not defined; consider updating this check to use the new LocalDnsServer implementation or adding the required function.
if local_dns::is_installed(&crate::local_config::managed_domains(Some(state), &None)) {
linkup-cli/src/commands/health.rs:81
- Typo in struct name 'BackgroudServices'; consider renaming to 'BackgroundServices'.
struct BackgroudServices {
65f9d36 to
6c04ab2
Compare
6c04ab2 to
d72e286
Compare
ostenbom
approved these changes
Mar 31, 2025
augustoccesar
added a commit
that referenced
this pull request
Apr 9, 2025
This will be merged to release `3.0.0`. Closes SHIP-2057 ### Changelog: - Drop Caddy as a dependency and use self-signed certificates. - #201 - #207 - #212 - #215 - #217 - Drop dnsmasq as a dependency and use a local Hickory server. - #219 - #224 - Support pre-release (beta) versions based on changes to `next` branch. - #204 - #205 - #211 - #213 - #214 - #221 - Use anyhow for application errors instead of "global" thiserror enum. - #218 - Stop relying on pidfiles for background services - #222 - Move installation script from Bash to Python - #223 - #226 - Improve possible orphans resolution - #225 Thank you @diegomartinrecillas @ludwigbacklund @solveigsg12 and @jauniusmentimeter for beta testing it! ❤️
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This replaces the dependency on dnsmasq and spin up a local DNS server using Hickory.
Related to SHIP-2057
References