-
Notifications
You must be signed in to change notification settings - Fork 3
feat(cli, ci, next): generate pre-release version on next or dispatch #205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cli, ci, next): generate pre-release version on next or dispatch #205
Conversation
b27307c
to
c29d99b
Compare
4d70570
to
bee9a09
Compare
- name: Generate Next Release Version | ||
id: generate_version | ||
uses: actions/github-script@v6 | ||
with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
with: | |
with: | |
result-encoding: string |
default is json 😄 https://github.com/actions/github-script?tab=readme-ov-file#result-encoding
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it make a difference for what I'm using? 🤔
I'm setting the output manually from core.setOutput
and not really reading the result.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this only makes sense with my other comment 😆
|
||
core.info(`Set release version to ${nextVersion}`); | ||
|
||
core.setOutput('version', nextVersion); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just double checking: are you sure that this works? It only worked for me when inside an action.
this was the solution I got working for core-api as an example: https://github.com/mentimeter/core-api/blob/main/.github/workflows/tests.yml#L235
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup! I triggered manually to see if the flow worked!
Here is the workflow: https://github.com/mentimeter/linkup/actions/runs/13920704763
And here is the generated release: https://github.com/mentimeter/linkup/releases/tag/0.0.0-next-202503181015-46d5efe
.github/workflows/release-next.yml
Outdated
|
||
- name: Generate Next Release Version | ||
id: generate_version | ||
uses: actions/github-script@v6 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
uses: actions/github-script@v6 | |
uses: actions/github-script@v7 |
is there any reason to not use the latest? 👀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope! No reason. Updated on fa976f4
Add support to pre-release versions on `versioning`. Right now the only pre-release that will exist is `0.0.0-next-<timestamp>-<hash>`, so if there is a `pre-release` part of the version, we can ignore the base semver. PR for generating the pre-releases: #205 Closes SHIP-2016
This will be merged to release `3.0.0`. Closes SHIP-2057 ### Changelog: - Drop Caddy as a dependency and use self-signed certificates. - #201 - #207 - #212 - #215 - #217 - Drop dnsmasq as a dependency and use a local Hickory server. - #219 - #224 - Support pre-release (beta) versions based on changes to `next` branch. - #204 - #205 - #211 - #213 - #214 - #221 - Use anyhow for application errors instead of "global" thiserror enum. - #218 - Stop relying on pidfiles for background services - #222 - Move installation script from Bash to Python - #223 - #226 - Improve possible orphans resolution - #225 Thank you @diegomartinrecillas @ludwigbacklund @solveigsg12 and @jauniusmentimeter for beta testing it! ❤️
Example run: https://github.com/mentimeter/linkup/actions/runs/13920704763
Example generated release: https://github.com/mentimeter/linkup/releases/tag/0.0.0-next-202503181015-46d5efe
Closes SHIP-2017
Related to SHIP-2057