8000 feat(cli, ci, next): generate pre-release version on next or dispatch by augustoccesar · Pull Request #205 · mentimeter/linkup · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat(cli, ci, next): generate pre-release version on next or dispatch #205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Mar 18, 2025

Conversation

augustoccesar
Copy link
Collaborator
@augustoccesar augustoccesar commented Mar 18, 2025

@augustoccesar augustoccesar force-pushed the augustoccesar/generate-pre-releases-from-next branch from b27307c to c29d99b Compare March 18, 2025 08:29
@augustoccesar augustoccesar self-assigned this Mar 18, 2025
@augustoccesar augustoccesar force-pushed the augustoccesar/generate-pre-releases-from-next branch from 4d70570 to bee9a09 Compare March 18, 2025 10:15
@augustoccesar augustoccesar marked this pull request as ready for review March 18, 2025 10:25
@augustoccesar augustoccesar requested a review from a team March 18, 2025 10:25
- name: Generate Next Release Version
id: generate_version
uses: actions/github-script@v6
with:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
with:
with:
result-encoding: string

default is json 😄 https://github.com/actions/github-script?tab=readme-ov-file#result-encoding

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it make a difference for what I'm using? 🤔
I'm setting the output manually from core.setOutput and not really reading the result.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this only makes sense with my other comment 😆


core.info(`Set release version to ${nextVersion}`);

core.setOutput('version', nextVersion);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just double checking: are you sure that this works? It only worked for me when inside an action.
this was the solution I got working for core-api as an example: https://github.com/mentimeter/core-api/blob/main/.github/workflows/tests.yml#L235

Copy link
Collaborator Author
@augustoccesar augustoccesar Mar 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup! I triggered manually to see if the flow worked!
Here is the workflow: https://github.com/mentimeter/linkup/actions/runs/13920704763
And here is the generated release: https://github.com/mentimeter/linkup/releases/tag/0.0.0-next-202503181015-46d5efe


- name: Generate Next Release Version
id: generate_version
uses: actions/github-script@v6
Copy link
@lorainegarutti lorainegarutti Mar 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
uses: actions/github-script@v6
uses: actions/github-script@v7

is there any reason to not use the latest? 👀

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope! No reason. Updated on fa976f4

@augustoccesar augustoccesar merged commit e01dca4 into next Mar 18, 2025
6 checks passed
@augustoccesar augustoccesar deleted the augustoccesar/generate-pre-releases-from-next branch March 18, 2025 10:45
augustoccesar added a commit that referenced this pull request Mar 21, 2025
Add support to pre-release versions on `versioning`.
Right now the only pre-release that will exist is
`0.0.0-next-<timestamp>-<hash>`, so if there is a `pre-release` part of
the version, we can ignore the base semver.

PR for generating the pre-releases:
#205

Closes SHIP-2016
augustoccesar added a commit that referenced this pull request Apr 9, 2025
This will be merged to release `3.0.0`.

Closes SHIP-2057

### Changelog:
- Drop Caddy as a dependency and use self-signed certificates.
  - #201
  - #207
  - #212 
  - #215 
  - #217 
- Drop dnsmasq as a dependency and use a local Hickory server.
  - #219
  - #224
- Support pre-release (beta) versions based on changes to `next` branch.
  - #204
  - #205
  - #211 
  - #213 
  - #214 
  - #221
- Use anyhow for application errors instead of "global" thiserror enum.
  - #218 
- Stop relying on pidfiles for background services
  - #222 
- Move installation script from Bash to Python
  - #223 
  - #226
- Improve possible orphans resolution
  - #225  

Thank you @diegomartinrecillas @ludwigbacklund @solveigsg12 and
@jauniusmentimeter for beta testing it! ❤️
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0