feat(cli, next): use self signed certificates for local-dns #201
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TODO: Cleanup the worker from Caddy-related features
For now it should only be available on macos
852f61d to
c880cf2
Compare
This was referenced Mar 17, 2025
|
This will be merged now into |
augustoccesar
added a commit
that referenced
this pull request
Apr 9, 2025
This will be merged to release `3.0.0`. Closes SHIP-2057 ### Changelog: - Drop Caddy as a dependency and use self-signed certificates. - #201 - #207 - #212 - #215 - #217 - Drop dnsmasq as a dependency and use a local Hickory server. - #219 - #224 - Support pre-release (beta) versions based on changes to `next` branch. - #204 - #205 - #211 - #213 - #214 - #221 - Use anyhow for application errors instead of "global" thiserror enum. - #218 - Stop relying on pidfiles for background services - #222 - Move installation script from Bash to Python - #223 - #226 - Improve possible orphans resolution - #225 Thank you @diegomartinrecillas @ludwigbacklund @solveigsg12 and @jauniusmentimeter for beta testing it! ❤️
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This changes so that we don't need Caddy and the certificate management with the worker.
With this, when installing local-dns a Certificate Authority certificate is created for Linkup and allowed on the local machine.
Then other certificates for the subdomains are created and signed by that CA.
TODO (here or on follow-up)
Cleanup worker to remove unnecessary certificate management.nextbranch. We can do that later.Update the following PRs to remove Caddy:(decided to cancel those PRs for now and they can be revisited after we decide how this change will move forward)Update the required workflows to pass on PRs to include the new ones per target OS.nextbranch. We can do that later.Closes SHIP-1993
Related to SHIP-2057