8000 Align python and MATLAB classes for problem formulation by sandmaennchen · Pull Request #1160 · acados/acados · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Align python and MATLAB classes for problem formulation #1160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 19, 2024
Merged

Align python and MATLAB classes for problem formulation #1160

merged 2 commits into from
Jul 19, 2024

Conversation

sandmaennchen
Copy link
Contributor
@sandmaennchen sandmaennchen commented Jul 17, 2024 •
edited
Loading

This PR is a first step towards aligning the MATLAB interface with the python interface.

python changes:

  • new attributes dyn_impl_dae_fun_jac, dyn_impl_dae_jac, dyn_impl_dae_fun in the AcadosModel for generic external implicit dynamics
  • new attribute nlp_solver_warm_start_first_qp in AcadosOptions

MATLAB changes:

  • Renaming of internal classes acados_<...>_json to match corresponding python class Acados...
  • lots of option defaults added which are already available in python
  • remove rti_phase in formulation object, as it only makes sense to change this online

@sandmaennchen sandmaennchen force-pushed the align_python_and_matlab_interface branch 2 times, most recently from d27a200 to b2178be Compare July 18, 2024 14:36
@sandmaennchen sandmaennchen force-pushed the align_python_and_matlab_interface branch from b2178be to 2b51af7 Compare July 18, 2024 14:51
@sandmaennchen sandmaennchen requested a review from FreyJo July 18, 2024 15:10
@FreyJo FreyJo changed the title Align python and MATLAB interface Align python and MATLAB classes for problem formulation Jul 18, 2024
FreyJo
FreyJo approved these changes Jul 18, 2024
View reviewed changes
Copy link
Member
@FreyJo FreyJo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great to have this 👍

@FreyJo FreyJo merged commit edeba2e into acados:master Jul 19, 2024
10 checks passed
@FreyJo FreyJo deleted the align_python_and_matlab_interface branch July 19, 2024 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FreyJo FreyJo FreyJo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sandmaennchen @FreyJo
0