8000 Update problem formulation by sandmaennchen · Pull Request #1221 · acados/acados · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Update problem formulation #1221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 19 commits into from
Sep 5, 2024
Merged

Update problem formulation #1221

merged 19 commits into from
Sep 5, 2024

Conversation

sandmaennchen
Copy link
Contributor
@sandmaennchen sandmaennchen commented Aug 27, 2024 •
edited
Loading

This PR updates the problem formulation which is now valid for both the MATLAB and python interfaces 🥳

  • Improved some docstrings along the way.
  • Added note on the two Matlab interfaces and examples in the docs.

The section on solver options has been updated, but there is many more options which are not part of this document yet.

@sandmaennchen sandmaennchen marked this pull request as ready for review September 2, 2024 03:23
@sandmaennchen sandmaennchen requested a review from FreyJo September 2, 2024 03:24
FreyJo
FreyJo approved these changes Sep 2, 2024
View reviewed changes
Copy link
Member
@FreyJo FreyJo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pushed minor modifications and added some comments, which I hope you can address before merging :)

@sandmaennchen sandmaennchen mentioned this pull request Sep 4, 2024
Open
@FreyJo
Copy link
Member
FreyJo commented Sep 4, 2024

Found one last typo. Please merge if you like :)

@sandmaennchen sandmaennchen merged commit 12e7090 into acados:master Sep 5, 2024
11 checks passed
@sandmaennchen sandmaennchen deleted the update_problem_formulation branch September 5, 2024 01:46
@josipkh josipkh mentioned this pull request Sep 5, 2024
Merged
sandmaennchen pushed a commit that referenced this pull request Sep 6, 2024
@josipkh
A few typo fixes and minor changes in the problem formulation document (
c1ca187 
#1242)

This PR fixes a few typos noticed after #1221.
Also, there are some minor modifications suggested to improve
readability.
Thanks again for aligning the interfaces and the docs!
FreyJo added a commit that referenced this pull request Oct 7, 2024
@sandmaennchen @FreyJo
Update problem formulation (#1221)
f685e5c 
This PR updates the problem formulation which is now valid for both the
MATLAB and python interfaces 🥳
* Improved some docstrings along the way.
* Added note on the two Matlab interfaces and examples in the docs.

The section on solver options has been updated, but there is many more
options which are not part of this document yet.

---------

Co-authored-by: Jonathan Frey <jonathanpaulfrey@gmail.com>
FreyJo pushed a commit that referenced this pull request Oct 7, 2024
@josipkh @FreyJo
A few typo fixes and minor changes in the problem formulation document (
05b574f 
#1242)

This PR fixes a few typos noticed after #1221.
Also, there are some minor modifications suggested to improve
readability.
Thanks again for aligning the interfaces and the docs!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FreyJo FreyJo FreyJo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sandmaennchen @FreyJo
0