8000 C cleanup by FreyJo · Pull Request #1315 · acados/acados · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

C cleanup #1315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8000
Jump to bottom
Merged
merged 9 commits into from
Oct 25, 2024
Merged

C cleanup #1315

merged 9 commits into from
Oct 25, 2024

Conversation

FreyJo
Copy link
Member
@FreyJo FreyJo commented Oct 25, 2024 •
edited by sandmaennchen
Loading

Breaking changes in C interface

  • remove ocp_nlp_solver_opts_update, opts_update is called in ocp_nlp_solver_create
  • cleanup of redundant signatures:
    • signature of ocp_nlp_get_from_iterate changes (takes solver and not solver AND dims)
    • signature of ocp_nlp_set changes (takes solver and not solver AND config)
    • signature of ocp_nlp_get changes (takes solver and not solver AND config)
    • signature of ocp_nlp_get_at_stage changes (takes solver and not solver AND dims AND config)
  • setters for lb and ub have been removed

Other

  • formatting wind_turbine C examples, chain example

FreyJo
FreyJo commented Oct 25, 2024
View reviewed changes
Copy link
Member Author
@FreyJo FreyJo left a c 8000 omment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🧹

@sandmaennchen sandmaennchen merged commit f0073f9 into acados:master Oct 25, 2024
13 checks passed
@sandmaennchen sandmaennchen deleted the c_cleanup branch October 25, 2024 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sandmaennchen sandmaennchen sandmaennchen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FreyJo @sandmaennchen
0