8000 CI: Test with MATLAB on Windows by sandmaennchen · Pull Request #1332 · acados/acados · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

CI: Test with MATLAB on Windows #1332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 64 commits into from
Nov 12, 2024
Merged

CI: Test with MATLAB on Windows #1332

merged 64 commits into from
Nov 12, 2024

Conversation

sandmaennchen
Copy link
Contributor
@sandmaennchen sandmaennchen commented Oct 30, 2024 •
edited by FreyJo
Loading

This PR adds a CI workflow for testing MATLAB examples on Windows.

In addition, the following changes are made:

  • In the minimal p_global example, the solver and model names are now unique
  • Split the p_global example into different files to be able to run them selectively on Github Actions
  • removed code_gen_dir from MATLAB solvers and avoid cd calls

@sandmaennchen sandmaennchen marked this pull request as draft October 30, 2024 07:10
@sandmaennchen sandmaennchen changed the title Windows matlab ci CI: Test with MATLAB on Windows Oct 30, 2024
@FreyJo
Copy link
Member
FreyJo commented Oct 30, 2024

For reference a successful windows Matlab install log:
https://pastebin.com/QPEsxNNa

@sandmaennchen sandmaennchen force-pushed the windows_matlab_ci branch 4 times, most recently from 80f3e09 to f0fd345 Compare November 5, 2024 14:48
@sandmaennchen sandmaennchen requested a review from FreyJo November 5, 2024 15:55
@sandmaennchen sandmaennchen marked this pull request as ready for review November 5, 2024 15:55
FreyJo
FreyJo approved these changes Nov 5, 2024
View reviewed changes
Copy link
Member
@FreyJo FreyJo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🪟 🥳

@FreyJo FreyJo merged commit d2ea248 into acados:master Nov 12, 2024
14 checks passed
@FreyJo FreyJo deleted the windows_matlab_ci branch November 12, 2024 08:28
FreyJo added a commit to FreyJo/acados that referenced this pull request Nov 12, 2024
@sandmaennchen @FreyJo
CI: Test with MATLAB on Windows (acados#1332)
b824ac4 
This PR adds a CI workflow for testing MATLAB examples on Windows.

In addition, the following changes are made:
* In the minimal `p_global` example, the solver and model names are now
unique
* Split the `p_global` example into different files to be able to run
them selectively on Github Actions
* removed `code_gen_dir` from MATLAB solvers and avoid `cd` calls

---------

Co-authored-by: Jonathan Frey <jonathanpaulfrey@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FreyJo FreyJo FreyJo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sandmaennchen @FreyJo
0