-
Notifications
You must be signed in to change notification settings - Fork 272
Implement adaptive epsilon for regularizations: MIRROR
and PROJECT
#1462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sandmaennchen
approved these changes
Mar 12, 2025
interfaces/acados_template/acados_template/acados_ocp_options.py
Outdated
Show resolved
Hide resolved
sandmaennchen
approved these changes
Mar 13, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
🚀 |
Merged
FreyJo
added a commit
that referenced
this pull request
Mar 19, 2025
- fix test, run test on CI - add option: `reg_min_epsilon`: Minimum value for epsilon if regularize_method in ['PROJECT', 'MIRROR'] is used with reg_adaptive_eps. Default: 1e-8. - fix `reg_max_cond_block` default: 1e7 instead of 1e-7. Add check that it must be >= 1.0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New options:
reg_max_cond_block
: Maximum condition number per block when using regularize_method in ['PROJECT', 'MIRROR'] withreg_adaptive_eps
= True, Default: 1e-7reg_adaptive_eps
: Determines if epsilon is chosen adaptively in regularization used if regularize_method in ['PROJECT', 'MIRROR']If true, epsilon is chosen block-wise based on
reg_max_cond_block
.Otherwise, epsilon is chosen globally based on
reg_epsilon
.Default: False
Inspired by "A nonmonotone filter SQP method: local convergence and numerical results" by NICHOLAS I. M. GOULD, YUELING LOH, DANIEL P. ROBINSON, Sec. 5.1