8000 Gershgorin Levenberg Marquardt regularization by FreyJo · Pull Request #1473 · acados/acados · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Gershgorin Levenberg Marquardt regularization #1473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Mar 20, 2025
Merged

Conversation

FreyJo
Copy link
Member
@FreyJo FreyJo commented Mar 20, 2025

Implement new regularization module: GERSHGORIN_LEVENBERG_MARQUARDT.
Estimates the smallest eigenvalue of each Hessian block using Gershgorin circles and adds multiple of identity to each block, such that smallest eigenvalue after regularization is at least reg_epsilon.

@david0oo
Copy link
Contributor

Should be renamed into GERSHGORIN_SLEDGEHAMMER....

@FreyJo
Copy link
Member Author
FreyJo commented Mar 20, 2025

I would stick to the naming. The "normal" Levenberg-Marquardt term with a fixed value is way more brutal compared to the Gershgorin approach 🛏️ 🌹

@FreyJo FreyJo requested review from sandmaennchen and david0oo and removed request for sandmaennchen March 20, 2025 13:13
@david0oo
Copy link
Contributor

Considering a metaphoric level, the name sledgehammer gives a much deeper intuition than Levenberg-Marquardt, therefore, I would also consider renaming levenberg-marquardt to sledgehammer and keeping the gershgorin sledgehammer

@FreyJo FreyJo merged commit 01452a6 into acados:main Mar 20, 2025
14 checks passed
@FreyJo FreyJo deleted the glm_reg branch March 20, 2025 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0