Fix Github Action errors #1487
Merged
Fix Github Action errors #1487
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our CI workflows were failing, since the ubuntu automatically installs CMake 4.0.
This version throws an error when
cmake_minimum_required(VERSION 2.8.11)is set.It can be mitigated by compiling with
-DCMAKE_POLICY_VERSION_MINIMUM=3.5, but already prints a deprecation warning even then, saying we should directly go to 3.10.I am not sure if people actually use very old cmake versions, but updating the version requirement would also be an option at some point.
An alternative fix is in 1e2640e which changes
cmake_minimum_required(VERSION 2.8.11)tocmake_minimum_required(VERSION 2.8.11...4.0)for the relevant submodules.However, it is not clear to me what the effects are. In particular, I think this would cause issues with cmake > 4.0.
The documentation did not fully clarify directly:
https://cmake.org/cmake/help/latest/command/cmake_minimum_required.html