8000 Allow messages with no lifetime in size helpers by lorisleiva · Pull Request #583 · anza-xyz/kit · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Allow messages with no lifetime in size helpers #583

New issue

Have a question about this project? Sign up for a free GitHub account to o 8000 pen an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 9, 2025
Merged

Allow messages with no lifetime in size helpers #583

merged 1 commit into from
Jul 9, 2025

Conversation

lorisleiva
Copy link
Member
@lorisleiva lorisleiva commented Jun 26, 2025 •
edited
Loading

Now that we've allowed transaction messages to be compiled without a lifetime constraint, we can do the same with helpers that return the transaction size for a given message. This PR does just that.

@changeset-bot changeset-bot
Copy link
changeset-bot bot commented Jun 26, 2025 •
edited
Loading
8000

🦋 Changeset detected

Latest commit: daf1217

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 40 packages
Name Type
@solana/transactions Minor
@solana/compat Minor
@solana/kit Minor
@solana/react Minor
@solana/rpc-api Minor
@solana/rpc-graphql Minor
@solana/rpc-subscriptions-api Minor
@solana/signers Minor
@solana/transaction-confirmation Minor
@solana/rpc Minor
@solana/sysvars Minor
@solana/rpc-subscriptions Minor
@solana/accounts Minor
@solana/addresses Minor
@solana/assertions Minor
@solana/codecs-core Minor
@solana/codecs-data-structures Minor
@solana/codecs-numbers Minor
@solana/codecs-strings Minor
@solana/codecs Minor
@solana/errors Minor
@solana/fast-stable-stringify Minor
@solana/functional Minor
@solana/instructions Minor
@solana/keys Minor
@solana/nominal-types Minor
@solana/options Minor
@solana/programs Minor
@solana/promises Minor
@solana/rpc-parsed-types Minor
@solana/rpc-spec-types Minor
@solana/rpc-spec Minor
@solana/rpc-subscriptions-channel-websocket Minor
@solana/rpc-subscriptions-spec Minor
@solana/rpc-transformers Minor
@solana/rpc-transport-http Minor
@solana/rpc-types Minor
@solana/subscribable Minor
@solana/transaction-messages Minor
@solana/webcrypto-ed25519-polyfill Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

This was referenced Jun 26, 2025
Merged
Merged
@lorisleiva Graphite App
Copy link
Member Author
lorisleiva commented Jun 26, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@lorisleiva lorisleiva mentioned this pull request Jun 26, 2025
Merged
@bundlemon BundleMon
Copy link
bundlemon bot commented Jun 26, 2025 •
edited
Loading

BundleMon

Unchanged files (127)
Status Path Size Limits
✅ @solana/kit production bundle
kit/dist/index.production.min.js
 34.52KB -
✅ rpc-graphql/dist/index.browser.mjs
 18.82KB -
✅ rpc-graphql/dist/index.native.mjs
 18.82KB -
✅ rpc-graphql/dist/index.node.mjs
 18.82KB -
✅ errors/dist/index.node.mjs
 14.59KB -
✅ errors/dist/index.browser.mjs
 14.57KB -
✅ errors/dist/index.native.mjs
 14.57KB -
✅ transaction-messages/dist/index.browser.mjs
 7.37KB -
✅ transaction-messages/dist/index.native.mjs
 7.36KB -
✅ transaction-messages/dist/index.node.mjs
 7.36KB -
✅ codecs-data-structures/dist/index.native.mjs
 4.77KB -
✅ codecs-data-structures/dist/index.browser.mjs
 4.77KB -
✅ codecs-data-structures/dist/index.node.mjs
 4.77KB -
✅ webcrypto-ed25519-polyfill/dist/index.node.mj
s
 3.57KB -
✅ webcrypto-ed25519-polyfill/dist/index.browser
.mjs
 3.56KB -
✅ webcrypto-ed25519-polyfill/dist/index.native.
mjs
 3.54KB -
✅ rpc-subscriptions/dist/index.browser.mjs
 3.38KB -
✅ rpc-subscriptions/dist/index.node.mjs
 3.34KB -
✅ rpc-subscriptions/dist/index.native.mjs
 3.31KB -
✅ codecs-core/dist/index.browser.mjs
 3.3KB -
✅ codecs-core/dist/index.native.mjs
 3.3KB -
✅ codecs-core/dist/index.node.mjs
 3.3KB -
✅ addresses/dist/index.browser.mjs
 2.93KB -
✅ rpc-transformers/dist/index.browser.mjs
 2.93KB -
✅ rpc-transformers/dist/index.native.mjs
 2.93KB -
✅ addresses/dist/index.native.mjs
 2.93KB -
✅ addresses/dist/index.node.mjs
 2.93KB -
✅ rpc-transformers/dist/index.node.mjs
 2.93KB -
✅ kit/dist/index.browser.mjs
 2.71KB -
✅ kit/dist/index.native.mjs
 2.71KB -
✅ kit/dist/index.node.mjs
 2.71KB -
✅ signers/dist/index.browser.mjs
 2.63KB -
✅ signers/dist/index.native.mjs
 2.63KB -
✅ signers/dist/index.node.mjs
 2.62KB -
✅ codecs-strings/dist/index.browser.mjs
 2.53KB -
✅ codecs-strings/dist/index.node.mjs
 2.48KB -
✅ codecs-strings/dist/index.native.mjs
 2.45KB -
✅ transaction-confirmation/dist/index.node.mjs
 2.39KB -
✅ sysvars/dist/index.browser.mjs
 2.35KB -
✅ sysvars/dist/index.native.mjs
 2.34KB -
✅ transaction-confirmation/dist/index.native.mj
s
 2.34KB -
✅ sysvars/dist/index.node.mjs
 2.34KB -
✅ transaction-confirmation/dist/index.browser.m
js
 2.34KB -
✅ transactions/dist/index.browser.mjs
 2.3KB -
✅ transactions/dist/index.native.mjs
 2.3KB -
✅ transactions/dist/index.node.mjs
 2.29KB -
✅ rpc-subscriptions-spec/dist/index.node.mjs
 2.18KB -
✅ rpc-subscriptions-spec/dist/index.native.mjs
 2.13KB -
✅ rpc-subscriptions-spec/dist/index.browser.mjs
 2.13KB -
✅ keys/dist/index.browser.mjs
 2.02KB -
✅ keys/dist/index.native.mjs
 2.02KB -
✅ keys/dist/index.node.mjs
 2.02KB -
✅ codecs-numbers/dist/index.native.mjs
 2.01KB -
✅ codecs-numbers/dist/index.browser.mjs
 2.01KB -
✅ codecs-numbers/dist/index.node.mjs
 2.01KB -
✅ react/dist/index.native.mjs
 1.99KB -
✅ react/dist/index.browser.mjs
 1.99KB -
✅ react/dist/index.node.mjs
 1.99KB -
✅ rpc/dist/index.node.mjs
 1.95KB -
✅ rpc-transport-http/dist/index.browser.mjs
 1.91KB -
✅ rpc-transport-http/dist/index.native.mjs
 1.91KB -
✅ rpc/dist/index.native.mjs
 1.8KB -
✅ subscribable/dist/index.node.mjs
 1.8KB -
✅ rpc/dist/index.browser.mjs
 1.8KB -
✅ subscribable/dist/index.native.mjs
 1.75KB -
✅ subscribable/dist/index.browser.mjs
 1.74KB -
✅ rpc-transport-http/dist/index.node.mjs
 1.73KB -
✅ rpc-types/dist/index.browser.mjs
 1.53KB -
✅ rpc-types/dist/index.native.mjs
 1.53KB -
✅ rpc-types/dist/index.node.mjs
 1.53KB -
✅ rpc-subscriptions-channel-websocket/dist/inde
x.node.mjs
 1.33KB -
✅ rpc-subscriptions-channel-websocket/dist/inde
x.native.mjs
 1.27KB -
✅ rpc-subscriptions-channel-websocket/dist/inde
x.browser.mjs
 1.26KB -
✅ options/dist/index.browser.mjs
 1.18KB -
✅ options/dist/index.native.mjs
 1.18KB -
✅ options/dist/index.node.mjs
 1.17KB -
✅ accounts/dist/index.browser.mjs
 1.13KB -
✅ accounts/dist/index.native.mjs
 1.12KB -
✅ accounts/dist/index.node.mjs
 1.12KB -
✅ compat/dist/index.browser.mjs
 971B -
✅ compat/dist/index.native.mjs
 970B -
✅ compat/dist/index.node.mjs
 968B -
✅ rpc-spec-types/dist/index.browser.mjs
 964B -
✅ rpc-api/dist/index.browser.mjs
 963B -
✅ rpc-api/dist/index.native.mjs
 962B -
✅ rpc-spec-types/dist/index.native.mjs
 962B -
✅ rpc-api/dist/index.node.mjs
 961B -
✅ rpc-spec-types/dist/index.node.mjs
 961B -
✅ rpc-subscriptions-api/dist/index.native.mjs
 870B -
✅ rpc-subscriptions-api/dist/index.node.mjs
 869B -
✅ rpc-subscriptions-api/dist/index.browser.mjs
 868B -
✅ rpc-spec/dist/index.browser.mjs
 852B -
✅ rpc-spec/dist/index.native.mjs
 851B -
✅ rpc-spec/dist/index.node.mjs
 850B -
✅ promises/dist/index.browser.mjs
 799B -
✅ promises/dist/index.native.mjs
 798B -
✅ promises/dist/index.node.mjs
 797B -
✅ assertions/dist/index.browser.mjs
 783B -
✅ instructions/dist/index.browser.mjs
 769B -
✅ instructions/dist/index.native.mjs
 768B -
✅ instructions/dist/index.node.mjs
 767B -
✅ fast-stable-stringify/dist/index.browser.mjs
 726B -
✅ fast-stable-stringify/dist/index.native.mjs
 725B -
✅ assertions/dist/index.native.mjs
 724B -
✅ fast-stable-stringify/dist/index.node.mjs
 724B -
✅ assertions/dist/index.node.mjs
 723B -
✅ programs/dist/index.browser.mjs
 329B -
✅ programs/dist/index.native.mjs
 327B -
✅ programs/dist/index.node.mjs
 325B -
✅ event-target-impl/dist/index.node.mjs
 230B -
✅ functional/dist/index.browser.mjs
 154B -
✅ functional/dist/index.native.mjs
 152B -
✅ text-encoding-impl/dist/index.native.mjs
 152B -
✅ functional/dist/index.node.mjs
 151B -
✅ codecs/dist/index.browser.mjs
 137B -
✅ codecs/dist/index.native.mjs
 136B -
✅ codecs/dist/index.node.mjs
 134B -
✅ event-target-impl/dist/index.browser.mjs
 133B -
✅ ws-impl/dist/index.node.mjs
 131B -
✅ text-encoding-impl/dist/index.browser.mjs
 122B -
✅ text-encoding-impl/dist/index.node.mjs
 119B -
✅ ws-impl/dist/index.browser.mjs
 113B -
✅ crypto-impl/dist/index.node.mjs
 111B -
✅ crypto-impl/dist/index.browser.mjs
 109B -
✅ rpc-parsed-types/dist/index.browser.mjs
 66B -
✅ rpc-parsed-types/dist/index.native.mjs
 65B -
✅ rpc-parsed-types/dist/index.node.mjs
 63B -

No change in files bundle size

Final result: ✅

View report in BundleMon website ➡️

Current branch size history | Target branch size history

8000
@lorisleiva lorisleiva force-pushed the 06-26-allow_messages_with_no_lifetime_in_signer_api branch from 00bd413 to f9da826 Compare June 26, 2025 15:02
@lorisleiva lorisleiva force-pushed the 06-26-allow_messages_with_no_lifetime_in_size_helpers branch from cb55b34 to 00e5f4b Compare June 26, 2025 15:02
@lorisleiva lorisleiva marked this pull request as ready for review June 26, 2025 15:06
@github-actions GitHub Actions
Copy link
Contributor
github-actions bot commented Jun 26, 2025 •
edited
Loading

Documentation Preview: https://kit-docs-qy32amp9v-anza-tech.vercel.app

@lorisleiva lorisleiva force-pushed the 06-26-allow_messages_with_no_lifetime_in_size_helpers branch from 00e5f4b to 9a4e686 Compare June 26, 2025 15:29
@lorisleiva lorisleiva force-pushed the 06-26-allow_messages_with_no_lifetime_in_signer_api branch from f9da826 to 3724418 Compare June 26, 2025 15:29
This was referenced Jun 26, 2025
Merged
Draft
steveluscher
steveluscher approved these changes Jun 26, 2025
View reviewed changes
Copy link
Collaborator
@steveluscher steveluscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added via Giphy

@lorisleiva lorisleiva force-pushed the 06-26-allow_messages_with_no_lifetime_in_size_helpers branch from 9a4e686 to 75cd14a Compare June 27, 2025 10:00
@lorisleiva lorisleiva force-pushed the 06-26-allow_messages_with_no_lifetime_in_signer_api branch from 3724418 to f90bb9a Compare June 27, 2025 10:00
@lorisleiva lorisleiva force-pushed the 06-26-allow_messages_with_no_lifetime_in_size_helpers branch from 75cd14a to 41452b8 Compare July 1, 2025 09:18
@lorisleiva lorisleiva force-pushed the 06-26-allow_messages_with_no_lifetime_in_signer_api branch from f90bb9a to 3b03160 Compare July 1, 2025 09:18
@lorisleiva lorisleiva mentioned this pull request Jul 1, 2025
Merged
@lorisleiva lorisleiva force-pushed the 06-26-allow_messages_with_no_lifetime_in_size_helpers branch from 41452b8 to 721dacd Compare July 1, 2025 09:22
@lorisleiva lorisleiva force-pushed the 06-26-allow_messages_with_no_lifetime_in_signer_api branch from 3b03160 to 49bb83b Compare July 1, 2025 09:22
@lorisleiva lorisleiva force-pushed the 06-26-allow_messages_with_no_lifetime_in_signer_api branch from 49bb83b to beb5ccc Compare July 9, 2025 08:13
@lorisleiva lorisleiva force-pushed the 06-26-allow_messages_with_no_lifetime_in_size_helpers branch from 721dacd to a0cbc0d Compare July 9, 2025 08:13
@lorisleiva Graphite App
Copy link
Member Author
lorisleiva commented Jul 9, 2025 •
edited
Loading

Merge activity

  • Jul 9, 8:32 AM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Jul 9, 8:46 AM UTC: Graphite rebased this pull request as part of a merge.
  • Jul 9, 8:48 AM UTC: @lorisleiva merged this pull request with Graphite.

@lorisleiva lorisleiva changed the base branch from 06-26-allow_messages_with_no_lifetime_in_signer_api to graphite-base/583 July 9, 2025 08:41
@lorisleiva lorisleiva changed the base branch from graphite-base/583 to main July 9, 2025 08:44
@lorisleiva lorisleiva force-pushed the 06-26-allow_messages_with_no_lifetime_in_size_helpers branch from a0cbc0d to daf1217 Compare July 9, 2025 08:45
@lorisleiva lorisleiva merged commit a894d53 into main Jul 9, 2025
14 checks passed
@lorisleiva lorisleiva deleted the 06-26-allow_messages_with_no_lifetime_in_size_helpers branch July 9, 2025 08:48
@github-actions github-actions bot mentioned this pull request Jul 9, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steveluscher steveluscher steveluscher approved these changes

@mcintyre94 mcintyre94 Awaiting requested review from mcintyre94

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lorisleiva @steveluscher
0