Deprecate CompilableTransactionMessage
#584
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 1af5afc The changes in this PR will be included in the next version bump.
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This was referenced Jun 26, 2025
This stack of pull requests is managed by Graphite. Learn more about stacking. |
CompilableTransactionMessage
BundleMonFiles updated (4)
Unchanged files (123)
Total files change -582B -0.16% Final result: ✅ View report in BundleMon website ➡️ |
b01ee8e to
7601485
Compare
|
Documentation Preview: https://kit-docs-ayvdsulmd-anza-tech.vercel.app |
steveluscher
requested changes
Jun 26, 2025
Comment on lines
209
to
217
| it('asks for a replacement blockhash even when the transaction message has a blockhash lifetime', () => { | ||
| const transactionMessage = { | ||
| ...mockTransactionMessage, | ||
| lifetimeConstraint: MOCK_BLOCKHASH_LIFETIME_CONSTRAINT, | ||
| }; | ||
|
|
||
| getComputeUnitEstimateForTransactionMessage_INTERNAL_ONLY_DO_NOT_EXPORT({ | ||
| rpc, | ||
| transactionMessage: { | ||
| ...mockTransactionMessage, | ||
| lifetimeConstraint: MOCK_BLOCKHASH_LIFETIME_CONSTRAINT, | ||
| }, | ||
| transactionMessage, |
There was a problem hiding this comment.
Per #581, this is one of those opportunities where we can just leave the lifetimeConstraint out rather than to supply a fake one right? ie. this should be split into two tests, one where you don't supply one at all, and one where you supply one that just gets written over.
Comment on lines
-45
to
-50
| // HACK: Since the `compileTransaction()` method will not compile a transaction with no lifetime we | ||
| // supply a dummy lifetime. | ||
| const INVALID_BUT_SUFFICIENT_FOR_COMPILATION_BLOCKHASH = { | ||
| blockhash: '11111111111111111111111111111111' as Blockhash, | ||
| lastValidBlockHeight: 0n, // This is not included in compiled transactions; it can be anything. | ||
| } as const; |
9a4e686 to
75cd14a
Compare
6e65787 to
df62f6d
Compare
75cd14a to
41452b8
Compare
df62f6d to
2f5b244
Compare
41452b8 to
721dacd
Compare
2f5b244 to
49de3a2
Compare
721dacd to
a0cbc0d
Compare
49de3a2 to
2e02696
Compare
Merge activity
|
2e02696 to
1af5afc
Compare
steveluscher
pushed a commit
that referenced
this pull request
Jul 14, 2025
This PR adjusts some of the changesets of a [previously merged PR stack](#584) such that `major` bumps are used when breaking changes are introduced.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR deprecated the
CompilableTransactionMessagetype and removes internal usages of that type.