8000 Extract lifetime from `CompiledTransactionMessage` by lorisleiva · Pull Request #594 · anza-xyz/kit · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Extract lifetime from CompiledTransactionMessage #594

New issue

Have a question about this project? Sign up for a free GitHub account to 8000 open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 9, 2025
Merged

Extract lifetime from CompiledTransactionMessage #594

merged 1 commit into from
Jul 9, 2025

Conversation

lorisleiva
Copy link
Member
@lorisleiva lorisleiva commented Jul 1, 2025 •
edited
Loading

This PR removes the lifetimeToken attribute from CompiledTransactionMessage and adds it to a new type CompiledTransactionMessageWithLifetime that can be composed with the former.

This enables CompiledTransactionMessages to be encoded without the need to specify a mock lifetime token and for decoded compiled messages to be typed as having a lifetime.

@changeset-bot changeset-bot
Copy link
changeset-bot bot commented Jul 1, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: 7336cbd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 40 packages
Name Type
@solana/transaction-messages Minor
@solana/kit Minor
@solana/programs Minor
@solana/rpc-api Minor
@solana/rpc-subscriptions-api Minor
@solana/signers Minor
@solana/transaction-confirmation Minor
@solana/transactions Minor
@solana/rpc Minor
@solana/sysvars Minor
@solana/rpc-subscriptions Minor
@solana/react Minor
@solana/compat Minor
@solana/rpc-graphql Minor
@solana/accounts Minor
@solana/addresses Minor
@solana/assertions Minor
@solana/codecs-core Minor
@solana/codecs-data-structures Minor
@solana/codecs-numbers Minor
@solana/codecs-strings Minor
@solana/codecs Minor
@solana/errors Minor
@solana/fast-stable-stringify Minor
@solana/functional Minor
@solana/instructions Minor
@solana/keys Minor
@solana/nominal-types Minor
@solana/options Minor
@solana/promises Minor
@solana/rpc-parsed-types Minor
@solana/rpc-spec-types Minor
@solana/rpc-spec Minor
@solana/rpc-subscriptions-channel-websocket Minor
@solana/rpc-subscriptions-spec Minor
@solana/rpc-transformers Minor
@solana/rpc-transport-http Minor
@solana/rpc-types Minor
@solana/subscribable Minor
@solana/webcrypto-ed25519-polyfill Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

This was referenced Jul 1, 2025
Merged
Merged
Merged
Merged
Merged
Draft
Closed
@lorisleiva Graphite App
Copy link
Member Author
lorisleiva commented Jul 1, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@bundlemon BundleMon
Copy link
bundlemon bot commented Jul 1, 2025 •
edited
Loading

BundleMon

Files updated (4)
Status Path Size Limits
✅ transaction-messages/dist/index.browser.mjs
 7.37KB (+77B +1.03%) -
✅ transaction-messages/dist/index.native.mjs
 7.36KB (+77B +1.03%) -
✅ transaction-messages/dist/index.node.mjs
 7.36KB (+77B +1.03%) -
✅ @solana/kit production bundle
kit/dist/index.production.min.js
 34.52KB (+16B +0.05%) -
Unchanged files (123)
Status Path Size Limits
✅ rpc-graphql/dist/index.browser.mjs
 18.82KB -
✅ rpc-graphql/dist/index.native.mjs
 18.82KB -
✅ rpc-graphql/dist/index.node.mjs
 18.82KB -
✅ errors/dist/index.node.mjs
 14.59KB -
✅ errors/dist/index.browser.mjs
 14.57KB -
✅ errors/dist/index.native.mjs
 14.57KB -
✅ codecs-data-structures/dist/index.native.mjs
 4.77KB -
✅ codecs-data-structures/dist/index.browser.mjs
 4.77KB -
✅ codecs-data-structures/dist/index.node.mjs
 4.77KB -
✅ webcrypto-ed25519-polyfill/dist/index.node.mj
s
 3.57KB -
✅ webcrypto-ed25519-polyfill/dist/index.browser
.mjs
 3.56KB -
✅ webcrypto-ed25519-polyfill/dist/index.native.
mjs
 3.54KB -
✅ rpc-subscriptions/dist/index.browser.mjs
 3.38KB -
✅ rpc-subscriptions/dist/index.node.mjs
 3.34KB -
✅ rpc-subscriptions/dist/index.native.mjs
 3.31KB -
✅ codecs-core/dist/index.browser.mjs
 3.3KB -
✅ codecs-core/dist/index.native.mjs
 3.3KB -
✅ codecs-core/dist/index.node.mjs
 3.3KB -
✅ addresses/dist/index.browser.mjs
 2.93KB -
✅ rpc-transformers/dist/index.browser.mjs
 2.93KB -
✅ rpc-transformers/dist/index.native.mjs
 2.93KB -
✅ addresses/dist/index.native.mjs
 2.93KB -
✅ addresses/dist/index.node.mjs
 2.93KB -
✅ rpc-transformers/dist/index.node.mjs
 2.93KB -
✅ kit/dist/index.browser.mjs
 2.71KB -
✅ kit/dist/index.native.mjs
 2.71KB -
✅ kit/dist/index.node.mjs
 2.71KB -
✅ signers/dist/index.browser.mjs
 2.63KB -
✅ signers/dist/index.native.mjs
 2.63KB -
✅ signers/dist/index.node.mjs
 2.62KB -
✅ codecs-strings/dist/index.browser.mjs
 2.53KB -
✅ codecs-strings/dist/index.node.mjs
 2.48KB -
✅ codecs-strings/dist/index.native.mjs
 2.45KB -
✅ transaction-confirmation/dist/index.node.mjs
 2.39KB -
✅ sysvars/dist/index.browser.mjs
 2.35KB -
✅ sysvars/dist/index.native.mjs
 2.34KB -
✅ transaction-confirmation/dist/index.native.mj
s
 2.34KB -
✅ sysvars/dist/index.node.mjs
 2.34KB -
✅ transaction-confirmation/dist/index.browser.m
js
 2.34KB -
✅ transactions/dist/index.browser.mjs
 2.3KB -
✅ transactions/dist/index.native.mjs
 2.3KB -
✅ transactions/dist/index.node.mjs
 2.29KB -
✅ rpc-subscriptions-spec/dist/index.node.mjs
 2.18KB -
✅ rpc-subscriptions-spec/dist/index.native.mjs
 2.13KB -
✅ rpc-subscriptions-spec/dist/index.browser.mjs
 2.13KB -
✅ keys/dist/index.browser.mjs
 2.02KB -
✅ keys/dist/index.native.mjs
 2.02KB -
✅ keys/dist/index.node.mjs
 2.02KB -
✅ codecs-numbers/dist/index.native.mjs
 2.01KB -
✅ codecs-numbers/dist/index.browser.mjs
 2.01KB -
✅ codecs-numbers/dist/index.node.mjs
 2.01KB -
✅ react/dist/index.native.mjs
 1.99KB -
✅ react/dist/index.browser.mjs
 1.99KB -
✅ react/dist/index.node.mjs
 1.99KB -
✅ rpc/dist/index.node.mjs
 1.95KB -
✅ rpc-transport-http/dist/index.browser.mjs
 1.91KB -
✅ rpc-transport-http/dist/index.native.mjs
 1.91KB -
✅ rpc/dist/index.native.mjs
 1.8KB -
✅ subscribable/dist/index.node.mjs
 1.8KB -
✅ rpc/dist/index.browser.mjs
 1.8KB -
✅ subscribable/dist/index.native.mjs
 1.75KB -
✅ subscribable/dist/index.browser.mjs
 1.74KB -
✅ rpc-transport-http/dist/index.node.mjs
 1.73KB -
✅ rpc-types/dist/index.browser.mjs
 1.53KB -
✅ rpc-types/dist/index.native.mjs
 1.53KB -
✅ rpc-types/dist/index.node.mjs
 1.53KB -
✅ rpc-subscriptions-channel-websocket/dist/inde
x.node.mjs
 1.33KB -
✅ rpc-subscriptions-channel-websocket/dist/inde
x.native.mjs
 1.27KB -
✅ rpc-subscriptions-channel-websocket/dist/inde
x.browser.mjs
 1.26KB -
✅ options/dist/index.browser.mjs
 1.18KB -
✅ options/dist/index.native.mjs
 1.18KB -
✅ options/dist/index.node.mjs
 1.17KB -
✅ accounts/dist/index.browser.mjs
 1.13KB -
✅ accounts/dist/index.native.mjs
 1.12KB -
✅ accounts/dist/index.node.mjs
 1.12KB -
✅ compat/dist/index.browser.mjs
 971B -
✅ compat/dist/index.native.mjs
 970B -
✅ compat/dist/index.node.mjs
 968B -
✅ rpc-spec-types/dist/index.browser.mjs
 964B -
✅ rpc-api/dist/index.browser.mjs
 963B -
✅ rpc-api/dist/index.native.mjs
 962B -
✅ rpc-spec-types/dist/index.native.mjs
 962B -
✅ rpc-api/dist/index.node.mjs
 961B -
✅ rpc-spec-types/dist/index.node.mjs
 961B -
✅ rpc-subscriptions-api/dist/index.native.mjs
 870B -
✅ rpc-subscriptions-api/dist/index.node.mjs
 869B -
✅ rpc-subscriptions-api/dist/index.browser.mjs
 868B -
✅ rpc-spec/dist/index.browser.mjs
 852B -
✅ rpc-spec/dist/index.native.mjs
 851B -
✅ rpc-spec/dist/index.node.mjs
 850B -
✅ promises/dist/index.browser.mjs
 799B -
✅ promises/dist/index.native.mjs
 798B -
✅ promises/dist/index.node.mjs
 797B -
✅ assertions/dist/index.browser.mjs
 783B -
✅ instructions/dist/index.browser.mjs
 769B -
✅ instructions/dist/index.native.mjs
 768B -
✅ instructions/dist/index.node.mjs
 767B -
✅ fast-stable-stringify/dist/index.browser.mjs
 726B -
✅ fast-stable-stringify/dist/index.native.mjs
 725B -
✅ assertions/dist/index.native.mjs
 724B -
✅ fast-stable-stringify/dist/index.node.mjs
 724B -
✅ assertions/dist/index.node.mjs
 723B -
✅ programs/dist/index.browser.mjs
 329B -
✅ programs/dist/index.native.mjs
 327B -
✅ programs/dist/index.node.mjs
 325B -
✅ event-target-impl/dist/index.node.mjs
 230B -
✅ functional/dist/index.browser.mjs
 154B -
✅ functional/dist/index.native.mjs
 152B -
✅ text-encoding-impl/dist/index.native.mjs
 152B -
✅ functional/dist/index.node.mjs
 151B -
✅ codecs/dist/index.browser.mjs
 137B -
✅ codecs/dist/index.native.mjs
 136B -
✅ codecs/dist/index.node.mjs
 134B -
✅ event-target-impl/dist/index.browser.mjs
 133B -
✅ ws-impl/dist/index.node.mjs
 131B -
✅ text-encoding-impl/dist/index.browser.mjs
 122B -
✅ text-encoding-impl/dist/index.node.mjs
 119B -
✅ ws-impl/dist/index.browser.mjs
 113B -
✅ crypto-impl/dist/index.node.mjs
 111B -
✅ crypto-impl/dist/index.browser.mjs
 109B -
✅ rpc-parsed-types/dist/index.browser.mjs
 66B -
✅ rpc-parsed-types/dist/index.native.mjs
 65B -
✅ rpc-parsed-types/dist/index.node.mjs
 63B -

Total files change +247B +0.07%

Final result: ✅

View report in BundleMon website ➡️

Current branch size history | Target branch size history

@lorisleiva lorisleiva force-pushed the 07-01-extract_lifetime_from_compiledtransactionmessage_ branch from 5204d4d to 8b1dc17 Compare July 1, 2025 09:22
@github-actions GitHub Actions
Copy link
Contributor
github-actions bot commented Jul 1, 2025 •
edited
Loading

Documentation Preview: https://kit-docs-fs0wpt5nk-anza-tech.vercel.app

@lorisleiva lorisleiva marked this pull request as ready for review July 1, 2025 09:30
@lorisleiva lorisleiva requested review from steveluscher and mcintyre94 and removed request for steveluscher July 1, 2025 09:30
steveluscher
steveluscher approved these changes Jul 8, 2025
View reviewed changes
Copy link
Collaborator
@steveluscher steveluscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added via Giphy

@lorisleiva lorisleiva force-pushed the 07-01-extract_lifetime_from_compiledtransactionmessage_ branch from 8b1dc17 to bdcb86e Compare July 9, 2025 08:13
@lorisleiva lorisleiva force-pushed the 06-26-allow_messages_with_no_lifetime_to_be_compiled branch from 2d89a8a to 5f77a74 Compare July 9, 2025 08:13
@lorisleiva Graphite App
Copy link
Member Author
lorisleiva commented Jul 9, 2025 •
edited
Loading

Merge activity

  • Jul 9, 8:32 AM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Jul 9, 8:37 AM UTC: Graphite rebased this pull request as part of a merge.
  • Jul 9, 8:40 AM UTC: @lorisleiva merged this pull request with Graphite.

@lorisleiva lorisleiva changed the base branch from 06-26-allow_messages_with_no_lifetime_to_be_compiled to graphite-base/594 July 9, 2025 08:33
@lorisleiva lorisleiva changed the base branch from graphite-base/594 to main July 9, 2025 08:36
@lorisleiva lorisleiva force-pushed the 07-01-extract_lifetime_from_compiledtransactionmessage_ branch from bdcb86e to 7336cbd Compare July 9, 2025 08:37
@lorisleiva lorisleiva merged commit 733605d into main Jul 9, 2025
14 checks passed
@lorisleiva lorisleiva deleted the 07-01-extract_lifetime_from_compiledtransactionmessage_ branch July 9, 2025 08:40
@github-actions github-actions bot mentioned this pull request Jul 9, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steveluscher steveluscher steveluscher approved these changes

@mcintyre94 mcintyre94 Awaiting requested review from mcintyre94

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lorisleiva @steveluscher
0