Allow compiled messages with no lifetime #587
Closed
+51
−29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: ab5f81e The changes in this PR will be included in the next version bump. This PR includes changesets to release 40 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This was referenced Jun 27, 2025
This stack of pull requests is managed by Graphite. Learn more about stacking. |
BundleMonFiles updated (7)
Unchanged files (120)
Total files change +392B +0.11% Final result: ✅ View report in BundleMon website ➡️ |
f2899ee to
a3524dd
Compare
|
@steveluscher @mcintyre94 If we're happy with this approach, I can insert it in the main PR stack. |
|
Documentation Preview: https://kit-docs-dkvblhm86-anza-tech.vercel.app |
a3524dd to
ab5f81e
Compare
lorisleiva
commented
Jun 27, 2025
Comment on lines
+318
to
+320
| if (!('lifetimeConstraint' in decompiledTransactionMessage)) { | ||
| throw new Error('We expect a lifetime'); | ||
| } |
There was a problem hiding this comment.
This showcases how this PR affects the developer experience. Here we know there will always be a lifetime constraint since we're fetching a transaction that landed so we need to assert the correct type.
|
Closing in favour of #594 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows
CompiledTransactionMessagesto have no lifetime constraint.It does it by filling the lifetime token with zeroes when encoding the message — that is, at the very last possible moment.
In order to have reciprocity when decoding
CompiledTransactionMessages, the decoder also recognises a lifetime token filled with zeroes and translate this as anundefinedlifetime token.