WIP - Honda Regen support #2229
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sshane
reviewed
May 19, 2025
* draft * 4 * fast again * faster * debug * stash * revert * map inside map is simple for getting signal addr pairs + fast for getting Signal types inside addr ranges * unordered_map is faster * some clean up * more * more * more * more
Fix typo in _can_rx helper
docs: fix wording
Reduce for loop calls when enableDsu is false
* Reapply "enable cpplint" (commaai#2245) This reverts commit f960080. * include from root * revert that * clean that up * seriously?
* bump cppcheck to 2.17.1 * update
* Add safety headers to package * include path * it's for the whole project * update * guard
* Update interface.py * match torque
* fix * no useless restore keys
clean up interfaces cuz why it like that
* move back to port * much better * fix button type * fix * need to switch so it works on ports that don't use it, and makes more sense * otherwise it'd be * Revert "otherwise it'd be" This reverts commit 99a9504. * make sense
* hkg can: move low speed alert to carstate * whoops
* forgot for can fd, oops. create common func * code now explains itself
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1100
Still needs to be tested. Maybe check if these messages are found on other Honda cars. Maybe get a list of which Honda Cars have regen support (just hybrids?)