8000 [Release] Stage to Main by milo-pr-merge[bot] · Pull Request #4420 · adobecom/milo · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[Release] Stage to Main #4420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jun 18, 2025
Merged

[Release] Stage to Main #4420

merged 7 commits into from
Jun 18, 2025

Conversation

milo-pr-merge[bot]
Copy link
Contributor
@milo-pr-merge milo-pr-merge bot commented Jun 17, 2025

common base root URLs

Homepage : https://www.stage.adobe.com/
BACOM: https://business.stage.adobe.com/fr/
CC: https://www.stage.adobe.com/creativecloud.html
Blog: https://blog.stage.adobe.com/
Acrobat: https://www.stage.adobe.com/acrobat/online/sign-pdf.html

Milo:

GNav Test URLs

Gnav + Footer + Region Picker modal:

Thin Gnav + ThinFooter + Region Picker dropup:

Localnav + Promo:

Sticky Branch Banner:

Inline Branch Banner:

Blog

RTL Locale

Deva309 and others added 3 commits June 17, 2025 09:46
…on components (#4373)

Enhance accessibility and styling for mobile navigation components

Co-authored-by: Dev Ashish Sardana <glo77801@adobe.com>
* [MWPW-173618] - media checklist link break fix

* [MWPW-173618] - media checklist optimization

* [MWPW-173618] - code optimization

* [MWPW-173618] - media block type added
@milo-pr-merge
Copy link
Contributor Author
milo-pr-merge bot commented Jun 17, 2025

Testing can start @adobecom/bacom-sot @adobecom/creative-cloud-sot @adobecom/document-cloud-sot @adobecom/express-sot @adobecom/homepage-sot @adobecom/miq-sot @adobecom/blog-sot

Copy link
Contributor
aem-code-sync bot commented Jun 17, 2025

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link
Contributor

SNOW Change Request Transaction ID: 0000019746cb97b2-17799c7

@afmicka afmicka temporarily deployed to milo_pr_merge June 17, 2025 10:36 — with GitHub Actions Inactive
…on contrast / navigation title (#4355)

* Revert "MWPW-140452 - Icon authoring in milo using the federal repo a… (#3357)

Revert "MWPW-140452 - Icon authoring in milo using the federal repo and individual SVG assets (#3259)"

This reverts commit 81a5770.

* [Release] Stage to Main (#3497)

MWPW-165774 [Mobile-GNAV] page is not scrollable in live page (#3495)

* check for new nav when disabling ios scroll

* shortened the check from the previous commit

Co-authored-by: Raghav Sharma <118168183+sharmrj@users.noreply.github.com>

* [Release] Stage to Main (#3817)

* ENB-7820: Add values for event95 (#3782)

* Add values for event95

* Fix failing test case

* Remove spaces

* Minimal Impact: Add extra key for  other features

* Minimal Impact: change function name

* [MWPW-168691] - Aside cta shrink JP (#3785)

* [MWPW-168691] cta shrink fix

* [MWPW-168691] update

* [MWPW-168691] update

* [MWPW-168691] update

* [MWPW-168691] update

* [MWPW-168691] update

* [MWPW-168691] update

* [MWPW-168691] update

* [MWPW-168691] updated solution

* Revert "[MWPW-168691]"

This reverts commit a70f9ca.

Revert "[MWPW-168691] update"

This reverts commit 6aac2bc.

Revert "[MWPW-168691] update"

This reverts commit c0c6a34.

Revert "[MWPW-168691] update"

This reverts commit 017edf0.

Revert "[MWPW-168691] update"

This reverts commit 219e5fd.

Revert "[MWPW-168691] update"

This reverts commit a7df2b5.

Revert "[MWPW-168691] update"

This reverts commit 299a7d7.

Revert "[MWPW-168691] update"

This reverts commit 6709515.

Revert "[MWPW-168691] cta shrink fix"

This reverts commit c90eea6.

* MWPW-168691: Prevent cta jp word wrap on large screens

* MWPW-168691: Fix notification jp cta

* MWPW-168691: Hide wbr cta for tablet and desktop

---------

Co-authored-by: Ratko Zagorac <ratkozagorac@gmail.com>

* MWPW-169371 : Adding countryCode config to UNav (#3793)

* Adding countryCode config to UNav

* Updating countryCode for uk

* Updating for upperCase

* Passing countryCode according to MAS mapping for UCv3 cart

---------

Co-authored-by: Snehal Sonawane <sonawane@snehals-mbp.corp.adobe.com>
Co-authored-by: Snehal Sonawane <sonawane@Snehals-MacBook-Pro.local>

* MWPW-167716 Remove await from both gnav and georouting (#3680)

Made georouting and globalnavigation non blocking

* Lnav title and headline text overflow support (#3781)

* Lnav title text overflow support

* Fix for chevron icon top position

* Adding white space break for localnav menus

* Adding white space break for localnav menus

* Adding white space break for localnav list menus

* Inclufing white spaces to non menu items

* [MWPW-169500] SEO- Links check failing breaks Preflight (#3803)

fixed preflight seo links check

* MWPW-169732 Fetch resources from adobe.com/federal instead of https://main--federal--adobecom.aem.live/federal (#3813)

* on prod federal content for the standalone gnav and footer needs to come from

* handled situations where we're stage and when we're neither stage nor prod

* MWPW-169416 [MEP] stop treating remove action differently in preview (#3789)

* truly remove elements, even in preview

* unit test update

* fix for MWPW-169416, new remove action in MEP

* lint clean-up

---------

Co-authored-by: John Pratt <jpratt@adobe.com>

---------

Co-authored-by: Swati Mukherjee <swati020494@gmail.com>
Co-authored-by: Dušan Kosanović <dusan.kosanovic@hitthecode.com>
Co-authored-by: Ratko Zagorac <ratkozagorac@gmail.com>
Co-authored-by: sonawanesnehal3 <152426902+sonawanesnehal3@users.noreply.github.com>
Co-authored-by: Snehal Sonawane <sonawane@snehals-mbp.corp.adobe.com>
Co-authored-by: Snehal Sonawane <sonawane@Snehals-MacBook-Pro.local>
Co-authored-by: Raghav Sharma <118168183+sharmrj@users.noreply.github.com>
Co-authored-by: Bandana Laishram <bandanalaishram@gmail.com>
Co-authored-by: Robert Bogos <146744221+robert-bogos@users.noreply.github.com>
Co-authored-by: Vivian A Goodrich <101133187+vgoodric@users.noreply.github.com>
Co-authored-by: John Pratt <jpratt@adobe.com>

* MWPW-167191 Removed an unnecessary css url() that was causing a console error (#3824)

MWPW-167191 Removed an unnecessary css url() that was causing a console error (#3630)

* updated an svg inside a url() in the globalnav css to have data:image/svg+xml;utf8 inorder to prevent a console error

* changed a ; to a ,

* Removed the svg as it was unnecessary

Co-authored-by: Raghav Sharma <118168183+sharmrj@users.noreply.github.com>

* Reduce gnav lana sampleRate to 0.01% (#4150)

* Revert "Improve carousel accessibility (#4103)" from prod (#4195)

Revert "Improve carousel accessibility (#4103)"

This reverts commit 34d2016.

* Revert "[MWPW-173470] - Korea free trial restrict" (main) (#4236)

Revert "[MWPW-173470] - Korea free trial restrict (#4185)"

This reverts commit 351cfe6.

* MWPW-173888 + MWPW-173919: Appending extra options for relative urls & multiple cta reopen fix (#4237)

* MWPW-173875 direct to main

* Korea free trial restrict (#4282)

* [MWPW-173016] - block korea free trial links/buttons

* [MWPW-173016] - korea text filter added

* [MWPW-173016] - update if

* [MWPW-173016] - code optimization

* [MWPW-173016] - improve import

* [MWPW-173016] - modal check, string check added

* [MWPW-173016] - strings added

* [MWPW-173470] - update logic

* [MWPW-173470] - update logic

* [MWPW-173470] - update logic

* [MWPW-173470] - remove whitespace

* [MWPW-173470] - optimize

* [MWPW-173470] - remove variable

* [MWPW-173016] - optimize code

* [MWPW-173016] - group logic

* [MWPW-173016] - merch solution added

* [MWPW-173016] - merch ref comment added

* [MWPW-173470] - null safe

* [MWPW-173470] - code optimization

* [MWPW-173470] - nav korea restrict coverage

* [MWPW-173470] - fix eslint console error

---------

Co-authored-by: Dusan Kosanovic <dusan.kosanovic@hitthecode.com>

* Revert "[MWPW-173717] Hyphenate large headings on mobile (#4199)"

This reverts commit 7b82821.

* Update utilities.js (#4312)

Making a change to the utilities file

Co-authored-by: Saloni Jain <6162294+salonijain3@users.noreply.github.com>

* MWPW-173772 [merch-card-collection] introduce mobile filter text

* MWPW-173772 fix for catalog

* icon & display text mgt

* fix

* more fixes

* add more unit test

* fixing autoblock fill

* MWPW-173772 bump sidenav h2 font size by 1px

---------

Co-authored-by: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com>
Co-authored-by: Okan Sahin <39759830+mokimo@users.noreply.github.com>
Co-authored-by: Raghav Sharma <118168183+sharmrj@users.noreply.github.com>
Co-authored-by: Swati Mukherjee <swati020494@gmail.com>
Co-authored-by: Dušan Kosanović <dusan.kosanovic@hitthecode.com>
Co-authored-by: Ratko Zagorac <ratkozagorac@gmail.com>
Co-authored-by: sonawanesnehal3 <152426902+sonawanesnehal3@users.noreply.github.com>
Co-authored-by: Snehal Sonawane <sonawane@snehals-mbp.corp.adobe.com>
Co-authored-by: Snehal Sonawane <sonawane@Snehals-MacBook-Pro.local>
Co-authored-by: Bandana Laishram <bandanalaishram@gmail.com>
Co-authored-by: Robert Bogos <146744221+robert-bogos@users.noreply.github.com>
Co-authored-by: Vivian A Goodrich <101133187+vgoodric@users.noreply.github.com>
Co-authored-by: John Pratt <jpratt@adobe.com>
Co-authored-by: Chris Peyer <chrischrischris@users.noreply.github.com>
Co-authored-by: Angelo Statescu <angelostatescu.adobe@gmail.com>
Co-authored-by: Blaine Gunn <Blainegunn@gmail.com>
Co-authored-by: Rares Munteanu <overmyheadandbody@gmail.com>
Co-authored-by: Narcis Radu <github@narcisradu.ro>
Co-authored-by: Saloni Jain <6162294+salonijain3@users.noreply.github.com>
Co-authored-by: Mariia Lukianets <mariia.lukianets@gmail.com>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

@mokimo mokimo temporarily deployed to milo_pr_merge June 17, 2025 12:35 — with GitHub Actions Inactive
Revert "[Fire-Drill] This will have to get reverted by ryan (#4368)"

This reverts commit fdbaea6.
Dli3
Dli3 F438 approved these changes Jun 17, 2025
Copy link
@sigadamvenkata sigadamvenkata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we find a blocker bug in Gnav for RTL locales. details are in JIRa
https://jira.corp.adobe.com/browse/MWPW-175210

Added fix for close icon positon for rtl

Co-authored-by: Dev Ashish Sardana <glo77801@adobe.com>
Copy link
@sigadamvenkata sigadamvenkata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

given fix verified and stage regression completed. good from our end

@milo-pr-merge milo-pr-merge bot merged commit 337b357 into main Jun 18, 2025
28 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0