8000 feat: add download results file endpoint by almeidabbm · Pull Request #14841 · lightdash/lightdash · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: add download results file endpoint #14841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 15, 2025
Merged

feat: add download results file endpoint #14841

merged 1 commit into from
May 15, 2025

Conversation

almeidabbm
Copy link
Contributor
@almeidabbm almeidabbm commented May 15, 2025 •
edited
Loading

Relates to: Endpoint to download CSV from query uuid

Description:

  • Adds endpoint to get the results file URL. This is useful for sql runner download since it uses the raw results file and then generates the csv in the frontend: packages/frontend/src/features/sqlRunner/hooks/useDownloadResults.tsx

Note: missing columns from the return type, should be available after Save results columns to query_history table on execution

image

Reviewer actions

  • I have manually tested the changes in the preview environment
  • I have reviewed the code
  • I understand that "request changes" will block this PR from merging

@almeidabbm Graphite App
Copy link
Contributor Author
almeidabbm commented May 15, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@almeidabbm almeidabbm marked this pull request as ready for review May 15, 2025 17:12
@owlas owlas requested a deployment to 05-15-feat_add_download_results_file_endpoint - jaffle_db_pg_13 PR #14841 May 15, 2025 17:12 — with Render Abandoned
@owlas owlas temporarily deployed to 05-15-feat_add_download_results_file_endpoint - headless-browser PR #14841 May 15, 2025 17:12 — with Render Destroyed
@almeidabbm almeidabbm requested a review from ZeRego May 15, 2025 17:15
@owlas owlas temporarily deployed to 05-15-feat_add_download_results_file_endpoint - lightdash PR #14841 May 15, 2025 17:31 — with Render Destroyed
This was referenced May 15, 2025
Merged
Merged
Merged
Merged
@ZeRego ZeRego merged commit 37e8730 into main May 15, 2025
46 of 49 checks passed
@ZeRego ZeRego deleted the 05-15-feat_add_download_results_file_endpoint branch May 15, 2025 21:27
lightdash-bot pushed a commit that referenced this pull request May 15, 2025
@semantic-release-bot
chore(release): 0.1630.0
443d174 
# [0.1630.0](0.1629.0...0.1630.0) (2025-05-15)

### Features

* add download results file endpoint ([#14841](#14841)) ([37e8730](37e8730))
@lightdash-bot
Copy link
Collaborator

🎉 This PR is included in version 0.1630.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

This was referenced May 15, 2025
Merged
Merged
Closed
Merged
Closed
@ZeRego ZeRego mentioned this pull request May 27, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZeRego ZeRego ZeRego approved these changes

Assignees

@almeidabbm almeidabbm

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@almeidabbm @lightdash-bot @ZeRego @owlas
0