8000 feat: filter SQL chart with table viz by ZeRego · Pull Request #14880 · lightdash/lightdash · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: filter SQL chart with table viz #14880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 28, 2025
Merged

feat: filter SQL chart with table viz #14880

merged 3 commits into from
May 28, 2025

Conversation

ZeRego
Copy link
Collaborator
@ZeRego ZeRego commented May 20, 2025 •
edited
Loading

Closes:

Description:

Changes:

  • stop requesting unpivoted results in dashboard tiles
  • apply filters to table viz

table filter.gif

Reviewer actions

  • I have manually tested the changes in the preview environment
  • I have reviewed the code
  • I understand that "request changes" will block this PR from merging

This was referenced May 20, 2025
Merged
Merged
Merged
Merged
@ZeRego Graphite App
Copy link
Collaborator Author
ZeRego commented May 20, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@ZeRego ZeRego mentioned this pull request May 20, 2025
Closed
3 tasks
@ZeRego ZeRego requested a review from magnew May 20, 2025 10:25
@ZeRego ZeRego marked this pull request as ready for review May 20, 2025 10:25
@ZeRego ZeRego force-pushed the 05-15-feat_filter_sql_charts_in_dashboard branch from be7a281 to 0778ae5 Compare May 20, 2025 13:00
@ZeRego ZeRego force-pushed the 05-20-feat_filter_sql_chart_with_table_viz branch from c2dafed to 44a17de Compare May 20, 2025 13:00
@ZeRego ZeRego force-pushed the 05-15-feat_filter_sql_charts_in_dashboard branch from 0778ae5 to d928f63 Compare May 20, 2025 16:42
@ZeRego ZeRego force-pushed the 05-20-feat_filter_sql_chart_with_table_viz branch from 44a17de to a3491c8 Compare May 20, 2025 16:42
Base automatically changed from 05-15-feat_filter_sql_charts_in_dashboard to main May 20, 2025 17:04
@ZeRego ZeRego force-pushed the 05-20-feat_filter_sql_chart_with_table_viz branch from a3491c8 to 4f5ee80 Compare May 20, 2025 17:05
@ZeRego ZeRego moved this from 📝 To-Do to 🏗 In progress in Selected for Development May 20, 2025
@owlas owlas requested a deployment to 05-20-feat_filter_sql_chart_with_table_viz - jaffle_db_pg_13 PR #14880 May 20, 2025 17:05 — with Render Abandoned
@owlas owlas deployed to 05-20-feat_filter_sql_chart_with_table_viz - headless-browser PR #14880 May 20, 2025 17:05 — with Render Active
@ZeRego ZeRego requested a review from almeidabbm May 21, 2025 13:26
almeidabbm
almeidabbm requested changes May 21, 2025
View reviewed changes
@ZeRego ZeRego mentioned this pull request May 21, 2025
Closed
3 tasks
@ZeRego ZeRego moved this from 🏗 In progress to ⛔️ Blocked in Selected for Development May 22, 2025
@owlas owlas deployed to 05-20-feat_filter_sql_chart_with_table_viz - headless-browser PR #14880 May 23, 2025 17:10 — with Render Active
@ZeRego ZeRego force-pushed the 05-20-feat_filter_sql_chart_with_table_viz branch from 4f5ee80 to 2ccbf07 Compare May 24, 2025 08:25
@owlas owlas deployed to 05-20-feat_filter_sql_chart_with_table_viz - headless-browser PR #14880 May 24, 2025 08:25 — with Render Active
@ZeRego ZeRego moved this from ⛔️ Blocked to 🏗 In progress in Selected for Development May 27, 2025
@ZeRego ZeRego force-pushed the 05-20-feat_filter_sql_chart_with_table_viz branch from 2ccbf07 to ebb4ef4 Compare May 27, 2025 15:56
@ZeRego ZeRego temporarily deployed to 05-20-feat_filter_sql_chart_with_table_viz - lightdash PR #14880 May 27, 2025 15:56 — with Render Destroyed
@owlas owlas temporarily deployed to 05-20-feat_filter_sql_chart_with_table_viz - headless-browser PR #14880 May 27, 2025 15:56 — with Render Destroyed
@ZeRego ZeRego mentioned this pull request May 27, 2025
Merged
@ZeRego ZeRego requested a review from almeidabbm May 27, 2025 16:27
almeidabbm
almeidabbm approved these changes May 28, 2025
View reviewed changes
Copy link
Contributor
@almeidabbm almeidabbm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, columns are now correct in the filter 🚀

Noticed a bug which I believe to be unrelated to this change, but worth checking:

Screen.Recording.2025-05-28.at.12.43.17.mov

@ZeRego
Copy link
Collaborator Author
ZeRego commented May 28, 2025

Tested, columns are now correct in the filter 🚀

Noticed a bug which I believe to be unrelated to this change, but worth checking:

Screen.Recording.2025-05-28.at.12.43.17.mov

Merging this PR as we can replicate the issue in main

@ZeRego ZeRego merged commit c4a9429 into main May 28, 2025
45 of 49 checks passed
@ZeRego ZeRego deleted the 05-20-feat_filter_sql_chart_with_table_viz branch May 28, 2025 14:10
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Selected for Development May 28, 2025
lightdash-bot pushed a commit that referenced this pull request May 28, 2025
@semantic-release-bot
chore(release): 0.1660.0
7b1df2b 
# [0.1660.0](0.1659.3...0.1660.0) (2025-05-28)

### Features

* filter SQL chart with table viz ([#14880](#14880)) ([c4a9429](c4a9429))
@lightdash-bot
Copy link
Collaborator

🎉 This PR is included in version 0.1660.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@almeidabbm almeidabbm almeidabbm approved these changes

@magnew magnew Awaiting requested review from magnew

Assignees

@ZeRego ZeRego

Labels
released
Projects
Selected for Development
Archived in project
Milestone
🟣 Filter SQL charts on dashboards
Development

Successfully merging this pull request may close these issues.
4 participants
@ZeRego @lightdash-bot @almeidabbm @owlas
0