8000 feat: filter sql charts in dashboard by ZeRego · Pull Request #14846 · lightdash/lightdash · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: filter sql charts in dashboard #14846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
May 20, 2025
Merged

feat: filter sql charts in dashboard #14846

merged 8 commits into from
May 20, 2025

Conversation

ZeRego
Copy link
Collaborator
@ZeRego ZeRego commented May 15, 2025 •
edited
Loading

Closes: #14629

Description:

Note: Table viz is not supported atm

1

2

Reviewer actions

  • I have manually tested the changes in the preview environment
  • I have reviewed the code
  • I understand that "request changes" will block this PR from merging

< 8000 p class="ml-1 mb-2 mt-2" data-show-on-error hidden> Sorry, something went wrong.

This was referenced May 15, 2025
Merged
Merged
@ZeRego ZeRego marked this pull request as ready for review May 15, 2025 20:58
@ZeRego ZeRego mentioned this pull request May 15, 2025
Merged
3 tasks
@ZeRego Graphite App
Copy link
Collaborator Author
ZeRego commented May 15, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@ZeRego ZeRego force-pushed the 05-15-feat_filter_sql_charts_in_dashboard branch from 41137ab to 9d30298 Compare May 15, 2025 21:47
@ZeRego ZeRego force-pushed the 05-15-feat_api_support_dashboard_filters_with_column_references_in_sql_charts branch from 02f9e7e to 5f7b994 Compare May 15, 2025 21:47
This was referenced May 15, 2025
Merged
Merged
@ZeRego ZeRego force-pushed the 05-15-feat_api_support_dashboard_filters_with_column_references_in_sql_charts branch from 5f7b994 to 3c5042e Compare May 15, 2025 22:57
@ZeRego ZeRego force-pushed the 05-15-feat_filter_sql_charts_in_dashboard branch 2 times, most recently from ce43ba0 to bbe9506 Compare May 19, 2025 10:37
@ZeRego ZeRego force-pushed the 05-15-feat_api_support_dashboard_filters_with_column_references_in_sql_charts branch 2 times, most recently from 07e3b19 to d82aeba Compare May 19, 2025 10:57
@ZeRego ZeRego force-pushed the 05-15-feat_filter_sql_charts_in_dashboard branch from bbe9506 to 8f7c087 Compare May 19, 2025 10:57
@ZeRego ZeRego force-pushed the 05-15-feat_api_support_dashboard_filters_with_column_references_in_sql_charts branch from d82aeba to e754e3e Compare May 19, 2025 13:50
@ZeRego ZeRego force-pushed the 05-15-feat_filter_sql_charts_in_dashboard branch from 8f7c087 to 90c7e55 Compare May 19, 2025 13:50
@ZeRego ZeRego requested review from almeidabbm and magnew May 19, 2025 14:17
@ZeRego ZeRego force-pushed the 05-15-feat_api_support_dashboard_filters_with_column_references_in_sql_charts branch from e754e3e to 6f1e352 Compare May 19, 2025 14:21
@ZeRego ZeRego force-pushed the 05-15-feat_filter_sql_charts_in_dashboard branch 2 times, most recently from 46bd0e5 to fa6463a Compare May 19, 2025 16:31
@ZeRego ZeRego force-pushed the 05-15-feat_api_support_dashboard_filters_with_column_references_in_sql_charts branch from 3c25a6c to 5deac0b Compare May 19, 2025 16:31
@ZeRego ZeRego mentioned this pull request May 19, 2025
Closed
3 tasks
@ZeRego ZeRego force-pushed the 05-15-feat_filter_sql_charts_in_dashboard branch 2 times, most recently from dbc4e54 to be7a281 Compare May 20, 2025 09:31
almeidabbm
almeidabbm approved these changes May 20, 2025
View reviewed changes
Copy link
Contributor
@almeidabbm almeidabbm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe 8000 this comment to others. Learn more.

LGTM 🚀
image

@ZeRego ZeRego mentioned this pull request May 20, 2025
Merged
3 tasks
Base automatically changed from 05-15-feat_api_support_dashboard_filters_with_column_references_in_sql_charts to main May 20, 2025 12:47
@ZeRego ZeRego force-pushed the 05-15-feat_filter_sql_charts_in_dashboard branch from be7a281 to 0778ae5 Compare May 20, 2025 13:00
@owlas owlas requested a deployment to 05-15-feat_filter_sql_charts_in_dashboard - jaffle_db_pg_13 PR #14846 May 20, 2025 13:00 — with Render Abandoned
@owlas owlas deployed to 05-15-feat_filter_sql_charts_in_dashboard - headless-browser PR #14846 May 20, 2025 13:00 — with Render Active
@ZeRego ZeRego requested a deployment to 05-15-feat_filter_sql_charts_in_dashboard - jaffle_db_pg_13 PR #14846 May 20, 2025 14:17 — with Render Abandoned
@ZeRego ZeRego force-pushed the 05-15-feat_filter_sql_charts_in_dashboard branch from 0778ae5 to d928f63 Compare May 20, 2025 16:42
@ZeRego ZeRego temporarily deployed to 05-15-feat_filter_sql_charts_in_dashboard - lightdash PR #14846 May 20, 2025 16:42 — with Render Destroyed
@owlas owlas temporarily deployed to 05-15-feat_filter_sql_charts_in_dashboard - headless-browser PR #14846 May 20, 2025 16:42 — with Render Destroyed
@ZeRego ZeRego merged commit 9b2c49f into main May 20, 2025
46 of 49 checks passed
@ZeRego ZeRego deleted the 05-15-feat_filter_sql_charts_in_dashboard branch May 20, 2025 17:04
lightdash-bot pushed a commit that referenced this pull request May 20, 2025
@semantic-release-bot
chore(release): 0.1638.0
d4d4d37 
# [0.1638.0](0.1637.1...0.1638.0) (2025-05-20)

### Features

* filter sql charts in dashboard ([#14846](#14846)) ([9b2c49f](9b2c49f))
@lightdash-bot
Copy link
Collaborator

🎉 This PR is included in version 0.1638.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

This was referenced May 21, 2025
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@almeidabbm almeidabbm almeidabbm approved these changes

@magnew magnew Awaiting requested review from magnew

Assignees

@ZeRego ZeRego

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Populate filter options from SQL-based charts in dashboards
4 participants
@ZeRego @lightdash-bot @almeidabbm @owlas
0