feat: use new paginated endpoint for pivoted sql results #14845
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
This stack of pull requests is managed by Graphite. Learn more about stacking. |
almeidabbm
commented
May 15, 2025
Comment on lines
+22
to
+33
| const { groupByColumns, valuesColumns: valuesColumnsConfig } = | ||
| queryHistory.pivot_configuration; | ||
|
|
||
| // From ProjectService.pivotQueryWorkerTask | ||
| return groupByColumns && groupByColumns.length > 0 | ||
| ? Object.values(queryHistory.pivot_values_columns ?? {}) | ||
| : null; | ||
| : valuesColumnsConfig.map((col) => ({ | ||
| referenceField: col.reference, | ||
| pivotColumnName: `${col.reference}_${col.aggregation}`, | ||
| aggregation: col.aggregation, | ||
| pivotValues: [], | ||
| })); |
There was a problem hiding this comment.
We need this, because in the frontend a query that just aggregates results is considered a pivoted query and depends on the valuesColumns returned by the endpoint
486fd7d to
30c638b
Compare
03d62f9 to
d019b18
Compare
30c638b to
199ab61
Compare
199ab61 to
688ea63
Compare
This was referenced May 15, 2025
688ea63 to
2ba7882
Compare
|
|
d019b18 to
557cd78
Compare
7b1b0e4 to
5dfcc22
Compare
557cd
8000
78 to
41b5f35
Compare
d301f94 to
36c7bd6
Compare
36c7bd6 to
b742d6d
Compare
41b5f35 to
628eacf
Compare
Base automatically changed from
05-15-chore_fetch_results_from_new_endpoint
to
main
May 19, 2025 10:56
ZeRego
approved these changes
May 19, 2025
b742d6d to
264b6be
Compare
Comment on lines
+386
to
+391
| await new Promise<void>((resolve, reject) => { | ||
| readStream.on('end', () => { | ||
| res.end(); | ||
| resolve(); | ||
| }); | ||
| }); |
There was a problem hiding this comment.
The stream error event isn't being handled in this Promise wrapper. If the stream encounters an error during piping, the Promise will never resolve or reject, potentially causing the request to hang. Consider adding an error handler:
await new Promise<void>((resolve, reject) => {
readStream.on('end', () => {
res.end();
resolve();
});
readStream.on('error', (err) => {
reject(err);
});
});This ensures proper error propagation and prevents request timeouts when stream errors occur.
Suggested change
| await new Promise<void>((resolve, reject) => { | |
| readStream.on('end', () => { | |
| res.end(); | |
| resolve(); | |
| }); | |
| }); | |
| await new Promise<void>((resolve, reject) => { | |
| readStream.on('end', () => { | |
| res.end(); | |
| resolve(); | |
| }); | |
| readStream.on('error', (err) => { | |
| reject(err); | |
| }); | |
| }); |
Spotted by Diamond
Is this helpful? React 👍 or 👎 to let us know.
lightdash-bot
pushed a commit
that referenced
this pull request
May 19, 2025
# [0.1632.0](0.1631.1...0.1632.0) (2025-05-19) ### Features * use new paginated endpoint for pivoted sql results ([#14845](#14845)) ([a51d70b](a51d70b))
|
🎉 This PR is included in version 0.1632.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
This was referenced May 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to: Update FE Sql tiles to use the new paginated endpoints
Closes: #14633
Description:
POST /api/v2/projects/{projectUuid}/query/sql-chartto trigger the sql chart queryReviewer actions