8000 chore: fetch sql runner results from new endpoint by almeidabbm · Pull Request #14844 · lightdash/lightdash · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

chore: fetch sql runner results from new endpoint #14844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 19, 2025
Merged

chore: fetch sql runner results from new endpoint #14844

merged 3 commits into from
May 19, 2025

Conversation

almeidabbm
Copy link
Contributor
@almeidabbm almeidabbm commented May 15, 2025 •
edited
Loading

Relates to: Update FE Sql tiles to use the new paginated endpoints

Description:

  • Uses new POST /api/v2/projects/{projectUuid}/query/sql to fetch results for the sql runner results table
Screen.Recording.2025-05-15.at.19.37.50.mov

Reviewer actions

  • I have manually tested the changes in the preview environment
  • I have reviewed the code
  • I understand that "request changes" will block this PR from merging

@almeidabbm almeidabbm requested a review from ZeRego May 15, 2025 18:35
@almeidabbm almeidabbm self-assigned this May 15, 2025
@almeidabbm almeidabbm marked this pull request as ready for review May 15, 2025 18:35
This was referenced May 15, 2025
Merged
Merged
Merged
@almeidabbm Graphite App
Copy link
Contributor Author
almeidabbm commented May 15, 2025 •
edited by ZeRego
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@almeidabbm almeidabbm changed the title chore: fetch results from new endpoint chore: fetch sql runner results from new endpoint May 15, 2025
@almeidabbm almeidabbm marked this pull request as draft May 15, 2025 18:39
@almeidabbm almeidabbm mentioned this pull request May 15, 2025
Merged
3 tasks
Base automatically changed from 05-15-feat_add_download_results_file_endpoint to main May 15, 2025 21:27
@almeidabbm almeidabbm force-pushed the 05-15-chore_fetch_results_from_new_endpoint branch from 03d62f9 to d019b18 Compare May 15, 2025 21:39
@owlas owlas requested a deployment to 05-15-chore_fetch_results_from_new_endpoint - jaffle_db_pg_13 PR #14844 May 15, 2025 21:39 — with Render Abandoned
@owlas owlas deployed to 05-15-chore_fetch_results_from_new_endpoint - headless-browser PR #14844 May 15, 2025 21:39 — with Render Active
This was referenced May 15, 2025
Merged
Merged
@almeidabbm
Copy link
Contributor Author
almeidabbm commented May 15, 2025 •
edited
Loading 8000

TODO: need to implement backoff strategy like we do for useQueryResults - DONE

@almeidabbm almeidabbm force-pushed the 05-15-chore_fetch_results_from_new_endpoint branch from d019b18 to 557cd78 Compare May 16, 2025 13:19
@owlas owlas deployed to 05-15-chore_fetch_results_from_new_endpoint - headless-browser PR #14844 May 16, 2025 13:19 — with Render Active
@almeidabbm almeidabbm force-pushed the 05-15-chore_fetch_results_from_new_endpoint branch from 557cd78 to 41b5f35 Compare May 16, 2025 13:54
@owlas owlas deployed to 05-15-chore_fetch_results_from_new_endpoint - headless-browser PR #14844 May 16, 2025 13:54 — with Render Active
@almeidabbm almeidabbm marked this pull request as ready for review May 19, 2025 10:14
@ZeRego ZeRego force-pushed the 05-15-chore_fetch_results_from_new_endpoint branch from 41b5f35 to 628eacf Compare May 19, 2025 10:37
@owlas owlas temporarily deployed to 05-15-chore_fetch_results_from_new_endpoint - lightdash PR #14844 May 19, 2025 10:37 — with Render Destroyed
@owlas owlas temporarily deployed to 05-15-chore_fetch_results_from_new_endpoint - headless-browser PR #14844 May 19, 2025 10:37 — with Render Destroyed
@ZeRego
Copy link
Collaborator
ZeRego commented May 19, 2025

e2e passing

Screenshot 2025-05-19 at 11 30 55

@ZeRego ZeRego merged commit 9bf67b8 into main May 19, 2025
44 of 49 checks passed
@ZeRego ZeRego deleted the 05-15-chore_fetch_results_from_new_endpoint branch May 19, 2025 10:56
@lightdash-bot
Copy link
Collaborator

🎉 This PR is included in version 0.1632.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

This was referenced May 19, 2025
Closed
Merged
Closed
@ZeRego ZeRego mentioned this pull request May 27, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZeRego ZeRego ZeRego approved these changes

Assignees

@almeidabbm almeidabbm

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@almeidabbm @ZeRego @lightdash-bot @owlas
0